Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Using devfile.io samples for getting-started #104

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Jun 11, 2024

Screenshot 2024-06-11 at 18 06 28

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk ibuziuk requested a review from l0rd as a code owner June 11, 2024 16:06
Copy link

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggested a correction for the Django sample that points to a nodejs-basic.
Apart from that there are a couple of samples that don't use the devfile registry yet (but that may be completely normal and it's ok):

  • Quarkus uses the che-incubator sample
  • Ollama uses redhat-developer-demos sample

src/lib/try/TryOnline.svelte Outdated Show resolved Hide resolved
ibuziuk and others added 2 commits June 12, 2024 15:31
@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 18, 2024

@l0rd thanks for the review
updated Ollama sample with https://registry.devfile.io/devfiles/ollama/1.0.0
Regarding Quarkus I believe we would still need to use our sample from the che-incubator due to eclipse-che/che#22906

Update: I think it would be nice to move this quarkus sample from che-incubator to devfile org e.g - devfile/api#1604 (comment)

@l0rd
Copy link
Contributor

l0rd commented Jun 19, 2024

@ibuziuk I get an error when I try to start the Ollama sample:
image

The URL I have used: https://workspaces.openshift.com#https://registry.devfile.io/devfiles/ollama/1.0.0&storageType=ephemeral

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 19, 2024

@l0rd I believe it is a resource issue - the new node was not yet provisioned. I think we might need to tune autoscaler setup on Developer Sandbox (we are in the process of migrating production to Argo CD and probably need to do some fine-tuning for DWOC) cc: @dkwon17 there is a separate discussion for skipping FailedScheduling events by default - https://issues.redhat.com/browse/CRW-6590

@l0rd
Copy link
Contributor

l0rd commented Jun 19, 2024

I wasn't looking for the root cause. If users get a systematic workspace startup error, whatever the cause is, we should remove the sample until that get fixed no?

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 20, 2024

The issue has been reported to the Sandbox folks and for me the sample works now.
The root cause with the situation related to autoscale is going to be fixed as part of https://issues.redhat.com/browse/SANDBOX-659

@l0rd
Copy link
Contributor

l0rd commented Jun 20, 2024

The issue has been reported to the Sandbox folks and for me the sample works now. The root cause with the situation related to autoscale is going to be fixed as part of https://issues.redhat.com/browse/SANDBOX-659

I can still reproduce the problem. You think that's because my workspaces get scheduled on a different cluster than yours?

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 25, 2024

@l0rd could you please comment about this situation in https://issues.redhat.com/browse/SANDBOX-659
I believe there is some problem with autoscaler, but on m3 it seems to work fine for me right now.
Thank you for the feedback I will cross-check everything regarding Ollama during contribution of the Developer Sandbox activity - https://issues.redhat.com/browse/SANDBOX-621

@ibuziuk ibuziuk merged commit 5500008 into eclipse-che:main Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants