Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom public certificates #34

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Support custom public certificates #34

merged 1 commit into from
Aug 6, 2020

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Aug 4, 2020

This changes proposal adds an ability to provide custom certificates.
There is a new field in api configuration, called publicCrtPath, which represents a simple directory on file system, where certificates *.crt are located. All those certificates take into account during user requests.

export interface IRestAPIConfig {
    baseUrl?: string;
    headers?: any;
    // path to self signed certificate
    ssCrtPath?: string;
    // path to public certificates
>>    publicCrtPath?: string;
    loggingEnabled?: boolean;
    machineToken?: string;
    userToken?: string;
}

Issue: eclipse-che/che#17440

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's wait for @akurinnoy review

@akurinnoy
Copy link
Contributor

@vzhukovskii hello,

Here are a few lines you could update:
https://github.com/eclipse/che-workspace-client/pull/34/files#diff-f41e9d04a45c83f3b6f6e630f10117feR80
https://github.com/eclipse/che-workspace-client/pull/34/files#diff-f41e9d04a45c83f3b6f6e630f10117feR84
https://github.com/eclipse/che-workspace-client/pull/34/files#diff-f41e9d04a45c83f3b6f6e630f10117feR163

and replace

ca: certificateAuthority ? certificateAuthority : undefined

with

ca: certificateAuthority

Aside from that everything LGTM

@vzhukovs
Copy link
Contributor Author

vzhukovs commented Aug 4, 2020

@vzhukovskii hello,

Here are a few lines you could update:
https://github.com/eclipse/che-workspace-client/pull/34/files#diff-f41e9d04a45c83f3b6f6e630f10117feR80
https://github.com/eclipse/che-workspace-client/pull/34/files#diff-f41e9d04a45c83f3b6f6e630f10117feR84
https://github.com/eclipse/che-workspace-client/pull/34/files#diff-f41e9d04a45c83f3b6f6e630f10117feR163

and replace

ca: certificateAuthority ? certificateAuthority : undefined

with

ca: certificateAuthority

Aside from that everything LGTM

Updated. Thanks!

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants