Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s/OS infrastructure should use Ingresses/Service/Route as Che Server #12268

Closed
sleshchenko opened this issue Dec 22, 2018 · 3 comments
Closed
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Dec 22, 2018

Description

The idea is to make it possible to use base K8s/OS recipe content for workspaces. It comes from Devfile workflow.
Now a user is forced to declare machines and servers inside them to have his/her server available and exposed by Che.
K8s/OS infrastructures should support Ingresses/Service/Route in recipes and resolve these objects as Che Server. Like, Service is may be resolved automatically as an internal server, Ingress or Route may be resolved automatically as a public server.
Some Che Servers specified fields are not supported by native K8s/OS objects format, like path, detailed protocol http/https/ws/wss, 'secure'. So, it is needed to have some default values for them and introduce Che Specific annotations to explicitly configure Che Server via K8s/OS object.

@sleshchenko sleshchenko added kind/enhancement A feature request - must adhere to the feature request template. team/platform labels Dec 22, 2018
@sleshchenko
Copy link
Member Author

sleshchenko commented Dec 22, 2018

cc @ibuziuk
I see that you added supporting OpenShift Routes issue[1] into your sprint. Not sure that now it makes sense to implement supporting bare OpenShift Routes without resolving them as Che Servers as a separate issue. So, our teams need sync about it.

Update:
During a discussion with @skabashnyuk and @garagatyi was decided that creating Ingresses/Routes even without translating them to Che Server makes sense and should be implemented as a simpler solution that may be improved in the current issue.

[1] #11530

@sleshchenko
Copy link
Member Author

I updated my previous comment after discussion with @skabashnyuk and @garagatyi

@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019
@che-bot che-bot closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants