Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all che-theia related extensions/plugins in che-theia repository #12306

Closed
13 of 19 tasks
evidolob opened this issue Dec 28, 2018 · 5 comments
Closed
13 of 19 tasks

Move all che-theia related extensions/plugins in che-theia repository #12306

evidolob opened this issue Dec 28, 2018 · 5 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.

Comments

@evidolob
Copy link
Contributor

evidolob commented Dec 28, 2018

Description

As we discuss on che-dev mail we should move all Che + Theia related projects in one repo:
https://github.com/eclipse/che-theia

IDE1

IDE 2

Languages

ws-skeleton

Deprecated repository(delete or archive):

@evidolob evidolob added kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. team/ide2 labels Dec 28, 2018
vparfonov added a commit to eclipse-che/che-theia that referenced this issue Feb 26, 2019
@vparfonov
Copy link
Contributor

@slemeur
che-theia-emacs-plugin https://github.com/eclipse/che-theia-emacs-plugin
che-theia-vi-plugin https://github.com/eclipse/che-theia-vi-plugin
Probably will be better to use VS Code plugins instead of spend time on reworking our extensions to the plugins.
What do you think?

@dneary
Copy link
Contributor

dneary commented Feb 28, 2019

@vparfonov For me, the decision comes down to where to spend effort: is it better to identify the work required to make VS Code plugins to work, or to implement plugins for the feature for Che? Part of that depends on how much work is needed in each case, and how many other things will be enabled in each case.

In general, I would favour evaluating whether the equivalent VS Code plug-ins work - if they work today, great! Effort saved. And if they do not, then identifying which plug-in APIs or functionalities need work to enable them to work. At that point, you have information to decide whether to get the VS Code plug-ins working unchanged, or whether to "port" them to Theia.

@vparfonov
Copy link
Contributor

My personal experience give feeling it would be not fast. For example, we spent a lot of time for K8s plugin and still not done. But in same time covering API one time we will open the door for all plugins which use this API. There are potential risks of being not able to implement all existed VS Code APIs in Theia.
So if talk about this concrete plugin will be faster to transform it form Theia Extension to Theia Plugin, BTW it not covered all VI behavior instead of VS Code https://marketplace.visualstudio.com/items?itemName=vscodevim.vim.

@sunix
Copy link
Contributor

sunix commented Mar 1, 2019

che-theia repo should only contain plugins and extensions that are specific to Che

  • using Che api's
  • provide features that only works on Che use cases
  • features that have high value on Che

Because we would cover more and more of the VSCode extension API, the more we integrate VSCode extensions, the faster integration of new VSCode extension would be to implement.

IMHO, For all these reasons, we should not include emacs and vi plugins to che-theia repo.

evidolob added a commit to eclipse-che/che-theia that referenced this issue Mar 19, 2019
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob added a commit to eclipse-che/che-theia that referenced this issue Mar 19, 2019
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob added a commit to eclipse-che/che-theia that referenced this issue Mar 20, 2019
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob added a commit to eclipse-che/che-theia that referenced this issue Mar 22, 2019
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob added a commit to eclipse-che/che-theia that referenced this issue Mar 22, 2019
* eclipse-che/che#12306 move dashboard extension

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob added a commit to eclipse-che/che-theia that referenced this issue Mar 22, 2019
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob added a commit to eclipse-che/che-theia that referenced this issue Mar 25, 2019
eclipse-che/che#12306 move activity tracker extension

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@slemeur slemeur removed the Epic label Jul 1, 2019
@benoitf
Copy link
Contributor

benoitf commented Sep 2, 2019

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.
Projects
None yet
Development

No branches or pull requests

7 participants