Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support clonePath in devfile #12557

Closed
metlos opened this issue Jan 30, 2019 · 6 comments
Closed

Support clonePath in devfile #12557

metlos opened this issue Jan 30, 2019 · 6 comments
Assignees
@metlos
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@metlos
Copy link
Contributor

metlos commented Jan 30, 2019 •
edited
Loading

Description

Currently, all projects are cloned into direct subdirectories of CHE_PROJECTS_ROOT. This can be problematic for some tooling. Go, for example, requires projects to be cloned in a specific location under the root that corresponds to the repository in which the code is hosted.

We can support this in devfile by being able to specify a clonePath property that would be understood as a relative path.

The code would then be cloned to $CHE_PROJECTS_ROOT/<clonePath>.
@metlos metlos added kind/enhancement A feature request - must adhere to the feature request template. team/platform labels Jan 30, 2019
@metlos metlos mentioned this issue Jan 30, 2019
Closed
@slemeur slemeur mentioned this issue Jan 30, 2019
Closed
42 tasks
@metlos metlos mentioned this issue Jan 30, 2019
Closed
3 tasks
@benoitf
Copy link
Contributor

benoitf commented Jan 31, 2019

hello
is it checkoutPath or clonePath/cloneDir ?
AFAIK checkout in git is for switching branch

@benoitf
Copy link
Contributor

benoitf commented Feb 5, 2019

@metlos ? what is your opinion about checkoutPath name ? looks like more a old pattern for cvs/svn than for DVCS like git.

@metlos
Copy link
Contributor Author

metlos commented Feb 5, 2019

@benoitf I'm an old guy :) clonePath works equally well for me

@metlos metlos changed the title Support checkoutPath in devfile Support clonePath in devfile Feb 5, 2019
@metlos
Copy link
Contributor Author

metlos commented Feb 5, 2019

I've changed checkoutPath to clonePath in the PR title and description. Thanks for the suggestion @benoitf !

@benoitf
Copy link
Contributor

benoitf commented Feb 5, 2019

@metlos thanks.

@skabashnyuk skabashnyuk added the severity/P1 Has a major impact to usage or development of the system. label Mar 6, 2019
@skabashnyuk skabashnyuk mentioned this issue Mar 20, 2019
Closed
16 tasks
@metlos metlos self-assigned this Mar 20, 2019
@metlos metlos mentioned this issue Mar 28, 2019
Merged
@metlos
Copy link
Contributor Author

metlos commented Apr 2, 2019

Closing as this is now merged.

@metlos metlos closed this as completed Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metlos metlos

Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@metlos @benoitf @skabashnyuk