Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform users about what devifle was used to create a workspace with the factory #12741

Closed
skabashnyuk opened this issue Feb 22, 2019 · 7 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@skabashnyuk
Copy link
Contributor

Description

Since we may support different devfile names like: .devfile , devfile, Devfile, devfile.yaml, and because if devfile does not exist in the repository we may use default one it would be nice to inform users about what devfile we used to create a workspace.

Maybe somethign like Loading workspace from .devfile on this page.
12 28 58

Implementation can be separated into two phases.

  • Put information about used devfile in workspaceConfig attributes.
  • Display information in some places on UI.
@skabashnyuk skabashnyuk added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Feb 22, 2019
@skabashnyuk
Copy link
Contributor Author

CC @l0rd @slemeur

@l0rd
Copy link
Contributor

l0rd commented Feb 22, 2019

What is most important is the case when no devfile is found in the repository. We should inform the user about it and that a generic development stack will be used.

@mshaposhnik mshaposhnik self-assigned this Mar 13, 2019
@skabashnyuk skabashnyuk added the severity/P1 Has a major impact to usage or development of the system. label Mar 13, 2019
@mshaposhnik
Copy link
Contributor

mshaposhnik commented Mar 15, 2019

Implemented as additional loading step:
Short demo with 2 cases - with and w/out devfile:
https://drive.google.com/file/d/1sHBfDwQSM4Wgx8hJNSMcqTIDlmrcM-mW/view?usp=sharing
@skabashnyuk @l0rd @slemeur wdyt ?

@l0rd
Copy link
Contributor

l0rd commented Mar 15, 2019

@mshaposhnik that works fine for me thanks. I think you could improve it in 2 ways:

  1. put the path of the devfile you are looking for (so that a dev will know how he need to call his devfile if it cannot be loaded)
  2. if possible make the "not found sentence" more visible (i.e. using bold chars)

@mshaposhnik
Copy link
Contributor

about the first - I'm added expected filename into message;
as for the second - i'm not sure it is possible with current dashb implenentation to set another text style for facory loading steps. The only avilable option yet is to fail step and make it bold red. If that strongly required we can make an separate issue.

@l0rd
Copy link
Contributor

l0rd commented Mar 18, 2019

@mshaposhnik that's ok if we cannot make it bold.

@mshaposhnik
Copy link
Contributor

Done in #12906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants