Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor Proposal] Add ability to change current theia workspace folder with help devfile. #13080

Closed
AndrienkoAleksandr opened this issue Apr 5, 2019 · 13 comments
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage.

Comments

@AndrienkoAleksandr
Copy link
Contributor

Description

On start che-theia we start che-theia with hard-coded theia workspace folder "/projects". Potentially we could implement ability to change theia workspace folder with help devfile. It's could be useful for go-lang workspaces.

@AndrienkoAleksandr AndrienkoAleksandr added the kind/enhancement A feature request - must adhere to the feature request template. label Apr 5, 2019
@skabashnyuk
Copy link
Contributor

@AndrienkoAleksandr #13006 is this something that can help you?

@AndrienkoAleksandr
Copy link
Contributor Author

No, I meant workspace theia path, not git subfolder path on project clone.

@sunix
Copy link
Contributor

sunix commented Apr 10, 2019

@AndrienkoAleksandr could you detail a complete workflow ? with a concrete example ?

@che-bot
Copy link
Contributor

che-bot commented Oct 9, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 9, 2019
@che-bot che-bot closed this as completed Oct 18, 2019
@tolusha tolusha removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2019
@tolusha tolusha reopened this Nov 4, 2019
@tolusha tolusha added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 4, 2019
@tolusha
Copy link
Contributor

tolusha commented Nov 4, 2019

I've reopened the issue since I've faced a real case when we need it.
Go language server requires the project to be the root of the workspace otherwise it can't find some imports.

eclipse-che/che-devfile-registry#96

Screenshot from 2019-11-04 09-45-25

@azatsarynnyy
Copy link
Member

I'm +1. Another case is the Kubernetes Tooling Che plugin. It also requires a project folder to be opened as a Theia Workspace root folder for executing some commands.

@tsmaeder
Copy link
Contributor

tsmaeder commented Nov 6, 2019

@tolusha I thought golang requires us to check out projects in a fixed location depending on the package name. Do you know how it would work in a setup with multiple workspace roots?

@tolusha
Copy link
Contributor

tolusha commented Nov 6, 2019

@tsmaeder Since 1.11 there is ability to put go project in a arbitrary folder.

[1] https://blog.golang.org/using-go-modules

@tsmaeder
Copy link
Contributor

tsmaeder commented Nov 6, 2019

@tolusha yes, but what do we need to pass to the language server to make it work? I thought we were multi-root safe for all languages. Could you confirm?

@benoitf benoitf added area/languages Issues related to Language extensions or plugins integration. team/languages severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 20, 2019
@benoitf benoitf added this to the Backlog - Languages milestone Nov 20, 2019
@tsmaeder
Copy link
Contributor

@tolusha ping?

@tolusha
Copy link
Contributor

tolusha commented Dec 18, 2019

From my understanding arbitrary folder will be set as workspace root and will be passed to LS.

@tsmaeder tsmaeder added the status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. label Feb 19, 2020
@tsmaeder
Copy link
Contributor

Depends on multi-root workspaces, AFAIC.

@sunix
Copy link
Contributor

sunix commented Jun 24, 2020

closing as duplicate of #15347 (which contains a implementation proposal)

@sunix sunix closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage.
Projects
None yet
Development

No branches or pull requests

8 participants