Add realworld go sample #96

tolusha · 2019-09-19T09:45:37Z

Signed-off-by: Anatoliy Bazko abazko@redhat.com

How to test

replace plugin id to with the reference

id: ms-vscode/go/latest

->

 reference: >-
      https://raw.githubusercontent.com/eclipse/che-plugin-registry/11ea1728310fd8ed6b26e904d4652d7aa14f166b/v3/plugins/ms-vscode/go/0.11.4/meta.yaml

Build docker.io/eclipse/che-remote-plugin-go-1.12.9:next (see Update go version to 1.12.9 che-theia#443)
or retag it from docker.io/abazko/che-remote-plugin-go-1.12.9:next

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

tolusha · 2019-09-20T05:32:37Z

I've added How to test section

devfiles/go-web-sample/devfile.yaml

nickboldt · 2019-09-23T16:36:26Z

devfiles/go/devfile.yaml

@@ -18,7 +18,7 @@ components:
 -
  type: dockerimage
  # this version is used in the plugin
-  image: quay.io/eclipse/che-golang-1.10:nightly
+  image: quay.io/eclipse/che-golang-1.12:nightly


do we need to support the go 1.10 stuff too? or just drop it in favour of the latest?

see also eclipse-che/che-plugin-registry#224

@nickboldt @amisevsk
~~I have no idea~~
I would say let's keep it for a while, is it ok?

I'm currently looking to deprecate 1.10 if possible, so if the devfiles work with 1.12, that makes my life easier.

See: eclipse-che/che#14265, #79 (comment)

amisevsk

I'm generally against adding pure backend samples to the devfiles registry as they provide a rather poor user experience (see the nodejs-mongo sample we're currently working on fixing).

amisevsk · 2019-09-24T00:57:18Z

devfiles/go-web-sample/devfile.yaml

+  memoryLimit: 512Mi
+-
+  type: dockerimage
+  # this version is used in the plugin


This comment is a worry; if the che plugin has latest version, will this devfile stop working when the plugin is eventually updated to use a later version?

I don't think so.

devfiles/go-web-sample/meta.yaml

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

tolusha · 2019-09-25T07:03:47Z

@amisevsk @l0rd @tsmaeder

I'm generally against adding pure backend samples to the devfiles registry as they provide a rather poor user experience (see the nodejs-mongo sample we're currently working on fixing).

It was decided here eclipse-che/che#13529
A lot of work has been done since then. Does it mean it was for nothing?

amisevsk · 2019-09-25T14:50:05Z

A lot of work has been done since then. Does it mean it was for nothing?

AFAICT the work that was done was very important for running Go on Che in the general case (if you're referring to issue eclipse-che/che#13803), so the work is not for nothing. The issue I have with applications that are only backend with no frontend is that we run into eclipse-che/che#14392 (which runs the same realworld backend app).

tolusha · 2019-09-26T11:42:02Z

I observed several issues:

Should be fixed by: Theia can't open files located in a sidecar container che#13614

Uncaught Error: 'file:///go/pkg/mod/github.com/jinzhu/gorm%40v1.9.8/main.go' has not been found.

Error: Request 'resolveContent' failed
    at Proxy.<anonymous> (https://static.developers.redhat.com/che/theia_artifacts/theia.d799fbdd096d798c68c8.js:1:1786120)
    at e.<anonymous> (https://static.developers.redhat.com/che/theia_artifacts/theia.d799fbdd096d798c68c8.js:1:1982608)
    at https://static.developers.redhat.com/che/theia_artifacts/theia.d799fbdd096d798c68c8.js:1:1981179
    at Object.next (https://static.developers.redhat.com/che/theia_artifacts/theia.d799fbdd096d798c68c8.js:1:1981284)
    at https://static.developers.redhat.com/che/theia_artifacts/theia.d799fbdd096d798c68c8.js:1:1980197
    at new Promise (<anonymous>)
    at T1Xs.a (https://static.developers.redhat.com/che/theia_artifacts/theia.d799fbdd096d798c68c8.js:1:1979974)
    at e.readContents (https://static.developers.redhat.com/che/theia_artifacts/theia.d799fbdd096d798c68c8.js:1:1982467)
    at new e (https://static.developers.redhat.com/che/theia_artifacts/theia.d799fbdd096d798c68c8.js:1:4362797)
    at e.<anonymous> (https://static.developers.redhat.com/che/theia_artifacts/theia.d799fbdd096d798c68c8.js:1:1469480)

Uncaught Error: Command failed: /go/bin/godef -t -i -f /projects/golang-web-app/store/user.go -o 177
Error: Command failed: /go/bin/godef -t -i -f /projects/golang-web-app/store/user.go -o 177

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

tolusha · 2019-11-04T07:39:38Z

@amisevsk
The PR is updated and is ready to test.

amisevsk

Tested and devfile works with a few caveats below.

Additionally: the golang plugin seems to be unable to handle methods on structs that are defined in other files (see article.go, which defines methods on handler). This is not an issue for this PR, though.

Finally, the project used in this devfile does not have a LICENSE file (like most realworld samples) and so will come with the same issues in redistribution: eclipse-che/che#14790

devfiles/go-web-sample/devfile.yaml

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

tolusha · 2019-11-06T08:17:23Z

Additionally: the golang plugin seems to be unable to handle methods on structs that are defined in other files (see article.go, which defines methods on handler). This is not an issue for this PR, though.

Actually it works. The trick is to set the project as a workspace root. But there is no way to do it automatically, that's way this issue became important eclipse-che/che#13080

tolusha · 2019-11-06T08:20:20Z

@amisevsk
From my point of view this issue [1] should be fixed before merging.
As far as I understood, we have to replace the project with one having a proper license, correct?

[1] eclipse-che/che#13080

tsmaeder · 2019-11-06T09:50:30Z

@tolusha any reason we're using the the version from "xesina" instead of the version it was forked from (which is MIT licensed)?

tsmaeder · 2019-11-06T09:54:29Z

As far as I understood, we have to replace the project with one having a proper license, correct?

Strictly speaking, no we don't: we're not distributing the sample, just pointing to some code on github. However, if we want to distribute the sample (in a airgapped version of CRW), we'll have to have the licensing in order.
That said, as an open source project, we should use examples that follow good practices for licensing, so yes, we should find an example that is properly licensed.

tolusha · 2019-11-06T10:22:32Z

@tsmaeder

any reason we're using the the version from "xesina" instead of the version it was forked from (which is MIT licensed)?

Which one? Probably I am not aware of.

tsmaeder · 2019-11-06T10:45:12Z

The repo is a github fork of another github project (which has a license)

tolusha · 2019-12-03T09:49:30Z

see comment eclipse-che/che#13803 (comment)

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>

tolusha added 2 commits September 19, 2019 12:44

Add realworld go sample

739083c

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Fix

63414b6

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

This was referenced Sep 19, 2019

Update go version to 1.12.9 eclipse-che/che-theia#443

Merged

Update go plugin to 0.11.4 and uses docker images with go 1.12.9 eclipse-che/che-plugin-registry#224

Merged

tolusha added 2 commits September 19, 2019 16:35

Fix

4327431

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Fix

48290b6

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

tolusha marked this pull request as ready for review September 19, 2019 13:36

tolusha requested review from l0rd, rhopp, skabashnyuk and vparfonov as code owners September 19, 2019 13:36

tolusha requested a review from amisevsk September 19, 2019 13:36

tolusha self-assigned this Sep 19, 2019

tolusha added the enhancement New feature or request label Sep 19, 2019

tsmaeder mentioned this pull request Sep 20, 2019

Languages Sprint 172 eclipse-che/che#14368

Closed

41 tasks

nickboldt suggested changes Sep 23, 2019

View reviewed changes

amisevsk reviewed Sep 24, 2019

View reviewed changes

benoitf reviewed Sep 24, 2019

View reviewed changes

devfiles/go-web-sample/meta.yaml Outdated Show resolved Hide resolved

tsmaeder mentioned this pull request Sep 24, 2019

Languages Sprint 173 eclipse-che/che#14640

Closed

30 tasks

Fixes

bef5acc

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Merge remote-tracking branch 'origin/master' into ab/go

afb07ed

Fix

38fd30b

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

tolusha mentioned this pull request Oct 9, 2019

Add go, cpp, python devfiles redhat-developer/devspaces#174

Merged

tsmaeder mentioned this pull request Oct 11, 2019

Languages Sprint 174 eclipse-che/che#14855

Closed

26 tasks

tolusha mentioned this pull request Oct 31, 2019

Install the latest version of the LS eclipse-che/che-theia#526

Merged

tsmaeder mentioned this pull request Oct 31, 2019

Languages Sprint 175 eclipse-che/che#15049

Closed

25 tasks

tolusha added 2 commits November 4, 2019 09:37

Merge master

31e9a6b

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

Fix

e0c3a18

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

tolusha mentioned this pull request Nov 4, 2019

[Minor Proposal] Add ability to change current theia workspace folder with help devfile. eclipse-che/che#13080

Closed

amisevsk reviewed Nov 5, 2019

View reviewed changes

devfiles/go-web-sample/devfile.yaml Outdated Show resolved Hide resolved

devfiles/go-web-sample/devfile.yaml Outdated Show resolved Hide resolved

amisevsk mentioned this pull request Nov 5, 2019

Review and fix sample projects licenses eclipse-che/che#14790

Open

Fix

cd07803

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

tsmaeder mentioned this pull request Nov 21, 2019

Languages Sprint 176 eclipse-che/che#15269

Closed

26 tasks

tolusha mentioned this pull request Dec 3, 2019

Upgrade Go version to support realworld sample eclipse-che/che#13803

Closed

tolusha closed this Dec 3, 2019

tolusha deleted the ab/go branch February 13, 2020 06:41

sparkoo pushed a commit to sparkoo/che-devfile-registry that referenced this pull request Dec 4, 2020

Introduce vscode-java plugin (eclipse-che#96)

1bd696b

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add realworld go sample #96

Add realworld go sample #96

tolusha commented Sep 19, 2019 •

edited

Loading

tolusha commented Sep 20, 2019

nickboldt Sep 23, 2019

nickboldt Sep 23, 2019

tolusha Sep 25, 2019 •

edited

Loading

amisevsk Sep 25, 2019

amisevsk left a comment

amisevsk Sep 24, 2019

tolusha Sep 25, 2019

tolusha commented Sep 25, 2019

amisevsk commented Sep 25, 2019

tolusha commented Sep 26, 2019

tolusha commented Nov 4, 2019

amisevsk left a comment

tolusha commented Nov 6, 2019

tolusha commented Nov 6, 2019

tsmaeder commented Nov 6, 2019

tsmaeder commented Nov 6, 2019

tolusha commented Nov 6, 2019

tsmaeder commented Nov 6, 2019

tolusha commented Dec 3, 2019

Add realworld go sample #96

Add realworld go sample #96

Conversation

tolusha commented Sep 19, 2019 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Related PRs

How to test

tolusha commented Sep 20, 2019

nickboldt Sep 23, 2019

Choose a reason for hiding this comment

nickboldt Sep 23, 2019

Choose a reason for hiding this comment

tolusha Sep 25, 2019 • edited Loading

Choose a reason for hiding this comment

amisevsk Sep 25, 2019

Choose a reason for hiding this comment

amisevsk left a comment

Choose a reason for hiding this comment

amisevsk Sep 24, 2019

Choose a reason for hiding this comment

tolusha Sep 25, 2019

Choose a reason for hiding this comment

tolusha commented Sep 25, 2019

amisevsk commented Sep 25, 2019

tolusha commented Sep 26, 2019

tolusha commented Nov 4, 2019

amisevsk left a comment

Choose a reason for hiding this comment

tolusha commented Nov 6, 2019

tolusha commented Nov 6, 2019

tsmaeder commented Nov 6, 2019

tsmaeder commented Nov 6, 2019

tolusha commented Nov 6, 2019

tsmaeder commented Nov 6, 2019

tolusha commented Dec 3, 2019

tolusha commented Sep 19, 2019 •

edited

Loading

tolusha Sep 25, 2019 •

edited

Loading