Theia can't open files located in a sidecar container #13614

tolusha · 2019-06-21T14:20:11Z

Description

Reproduction Steps

Start workspace with a Typescrip plugin.
Goto preferences and set typescript.tsserver.trace to verbose
Try to run command Open TS server log file
Server log file can't be opened

OS and version:
Che-7.0.0-CR2

Diagnostics:
LS sends request to Theia to open a log file but Theia can't find the file because it is located in a side-car container.

#13428

The text was updated successfully, but these errors were encountered:

tolusha · 2019-08-06T11:12:06Z

It is turned out to be a more general issue when plugin sends request to Theia to open an file that exists only in a sidecar container.

errors.ts:81 Uncaught Error: 'file:///usr/include/c%2B%2B/8/iostream' has not been found.

Error: Request 'resolveContent' failed
    at Proxy.<anonymous> (https://static.developers.redhat.com/che/theia_artifacts/theia.80ec0f4ae0530039ebdd.js:1:1742008)
    at e.<anonymous> (https://static.developers.redhat.com/che/theia_artifacts/theia.80ec0f4ae0530039ebdd.js:1:1918534)
    at https://static.developers.redhat.com/che/theia_artifacts/theia.80ec0f4ae0530039ebdd.js:1:1917105
    at Object.next (https://static.developers.redhat.com/che/theia_artifacts/theia.80ec0f4ae0530039ebdd.js:1:1917210)
    at https://static.developers.redhat.com/che/theia_artifacts/theia.80ec0f4ae0530039ebdd.js:1:1916123
    at new Promise (<anonymous>)
    at T1Xs.a (https://static.developers.redhat.com/che/theia_artifacts/theia.80ec0f4ae0530039ebdd.js:1:1915900)
    at e.readContents (https://static.developers.redhat.com/che/theia_artifacts/theia.80ec0f4ae0530039ebdd.js:1:1918393)
    at new e (https://static.developers.redhat.com/che/theia_artifacts/theia.80ec0f4ae0530039ebdd.js:1:4146586)
    at e.<anonymous> (https://static.developers.redhat.com/che/theia_artifacts/theia.80ec0f4ae0530039ebdd.js:1:1456739)
Caused by: Error: 'file:///usr/include/c%2B%2B/8/iostream' has not been found.
    at FileSystemNode.<anonymous> (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:160:64)
    at step (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:59:23)
    at Object.next (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:40:53)
    at fulfilled (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:31:58)
    at https://cdn.jsdelivr.net/npm/@typefox/monaco-editor-core@0.14.6/min/vs/editor/editor.main.js:158:350

tolusha · 2019-08-14T11:35:33Z

It is relatively easy to redirect a request to retrieve content from a side-car container, but we have to take into account that redirection matters only for files that are not available from a Theia container.

tsmaeder · 2019-08-15T14:23:24Z

An approach would be to rewrite some URIs (those not under /projects) when we get them from plugins and redispatch them to the plugin containers for resolving contents, etc. We should start a conversation about this on che-dev and do a spike first.

tolusha · 2019-08-27T14:50:41Z

The solution might be accomplished in following steps. (It has been tested yet)

Override scheme by adding a sidecar identifier (which is basically a machine name)
~~https://github.com/eclipse/che-theia/blob/ab/sidecarcontent/extensions/eclipse-che-theia-plugin-remote/src/node/content-container-aware.ts#L14~~
Binding content resolver to handle all those kind of schemes
~~https://github.com/eclipse/che-theia/blob/ab/sidecarcontent/extensions/eclipse-che-theia-plugin-ext/src/browser/che-sidecar-resource.ts#L49~~
Sending request to a sidecar container to retrieve the content
~~https://github.com/eclipse/che-theia/blob/ab/sidecarcontent/extensions/eclipse-che-theia-plugin-ext/src/browser/che-sidecar-content-resolver-main.ts#L27~~
Retrieve content in a sidecar container
~~https://github.com/eclipse/che-theia/blob/ab/sidecarcontent/extensions/eclipse-che-theia-plugin-ext/src/plugin/che-content-resolver.ts#L22~~

tsmaeder · 2019-08-28T07:43:08Z

@tolusha but if I understand correctly, the file being opened is, for example as a result of a "goto definition" request, which is not going through "open document".
I think the approach should be to change all api calls that return URI's to return an uri that is specific to the sidecar (unless it's a uri that is in a known shared area)

tolusha · 2019-08-28T08:30:36Z

It probably will require to override some other API calls but I don't know for sure which ones.

tsmaeder · 2019-08-28T10:31:28Z

@tolusha all of them which return a URI. But for a PoC, we could start with the case that fails with the CPP extension

tolusha · 2019-08-30T12:08:54Z

It is possible to open files from a sidecar container in the Theia

Override scheme by adding a sidecar identifier (which is basically a machine name)
https://github.com/eclipse/che-theia/blob/ab/scc/extensions/eclipse-che-theia-plugin-remote/src/node/content-container-aware.ts#L15
Binding content resolver to handle all those kind of schemes
https://github.com/eclipse/che-theia/blob/ab/scc/extensions/eclipse-che-theia-plugin-ext/src/browser/che-sidecar-resource.ts#L22
Sending request to a sidecar container to retrieve the content
https://github.com/eclipse/che-theia/blob/ab/scc/extensions/eclipse-che-theia-plugin-ext/src/browser/che-sidecar-content-reader-main.ts#L14
Retrieve content in a sidecar container
https://github.com/eclipse/che-theia/blob/ab/scc/extensions/eclipse-che-theia-plugin-ext/src/plugin/che-sidecar-content-reader.ts#L15

tolusha · 2019-09-03T11:23:27Z

We still have issue with gotoDefinition for c/c++ plugin

root INFO {exception: null, error: Error: Request 'resolveContent' failed
    at Proxy.<anonymous> (http://routejunfjjtr-che.192.168.9…, promise: n.C…s.d…e._creator, handler: undefined, id: 6, …}error: Error: Request 'resolveContent' failed
    at Proxy.<anonymous> (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:12:923880)
    at e.<anonymous> (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:150903)
    at http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:149492
    at Object.next (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:149597)
    at http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:148510
    at new Promise (<anonymous>)
    at a (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:148287)
    at e.readContents (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:150762)
    at new e (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:473498)
    at e.<anonymous> (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:12:768245)
Caused by: Error: 'file:///usr/include/c%2B%2B/8/iostream' has not been found.
    at FileSystemNode.<anonymous> (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:162:64)
    at step (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:59:23)
    at Object.next (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:40:53)
    at fulfilled (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:31:58)exception: nullhandler: undefinedid: 6parent: undefinedpromise: n.Class.derive._creator {_creator: null, _nextState: null, _state: {…}, _value: Error: Request 'resolveContent' failed
    at Proxy.<anonymous> (http://routejunfjjtr-che.192.168.9…, _listeners: null, …}__proto__: Object
editor.main.js:158 Uncaught Error: 'file:///usr/include/c%2B%2B/8/iostream' has not been found.

Error: Request 'resolveContent' failed
    at Proxy.<anonymous> (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:12:923880)
    at e.<anonymous> (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:150903)
    at http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:149492
    at Object.next (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:149597)
    at http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:148510
    at new Promise (<anonymous>)
    at a (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:148287)
    at e.readContents (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:150762)
    at new e (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:30:473498)
    at e.<anonymous> (http://routejunfjjtr-che.192.168.99.100.nip.io/bundle.js:12:768245)
Caused by: Error: 'file:///usr/include/c%2B%2B/8/iostream' has not been found.
    at FileSystemNode.<anonymous> (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:162:64)
    at step (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:59:23)
    at Object.next (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:40:53)
    at fulfilled (/home/theia/node_modules/@theia/filesystem/lib/node/node-filesystem.js:31:58)
    at http://routejunfjjtr-che.192.168.99.100.nip.io/vs/editor/editor.main.js:158:350

tsmaeder · 2019-09-03T11:40:47Z

@tolusha yes, we need to override all requests that return an uri from a sidecar, like "references", "definitions", etc, etc. We will not be able to catch them all (for example, if uri's are inside command parameters, which are unknown to us), but most of them.

tsmaeder · 2019-09-04T09:25:32Z

I think handling uri's in the languages namespace would go a long way: https://code.visualstudio.com/api/references/vscode-api#languages

tsmaeder · 2019-09-04T13:36:29Z

We'll start by fixing the issue with the C++ plugin and provide a PR for that (definitions provider).

tolusha · 2019-09-18T11:03:26Z

I've added overriding definition provider [1] and it allowed gotoDefinition feature works. The work isn't completed. Navigation in that file (iostream) doesn't work.

[1] https://github.com/eclipse/che-theia/blob/ab/scc/extensions/eclipse-che-theia-plugin-remote/src/node/languages-container-aware.ts#L22

tolusha added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 21, 2019

tolusha changed the title ~~Typescript command: Open TS server log file doesn't work~~ Theia can't open files located in a sidecar container Aug 6, 2019

slemeur mentioned this issue Aug 6, 2019

Add support for C/C++ #13698

Closed

20 tasks

This was referenced Aug 8, 2019

Languages Sprint 170 #14016

Closed

Languages Sprint 171 #14221

Closed

tsmaeder mentioned this issue Aug 29, 2019

Languages Sprint 172 #14368

Closed

41 tasks

tolusha self-assigned this Sep 2, 2019

azatsarynnyy mentioned this issue Sep 3, 2019

[Kubernetes Plugin] Kubernetes: Diff command doesn't open diff view when running in a sidecar #13044

Closed

tsmaeder mentioned this issue Sep 24, 2019

Languages Sprint 173 #14640

Closed

30 tasks

This was referenced Sep 26, 2019

Add realworld go sample eclipse-che/che-devfile-registry#96

Closed

Allow to open file in the Theia IDE from a sidecar container eclipse-che/che-theia#453

Merged

tsmaeder mentioned this issue Oct 11, 2019

Languages Sprint 174 #14855

Closed

26 tasks

tsmaeder added this to the 7.4.0 milestone Oct 16, 2019

tolusha closed this as completed Oct 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Theia can't open files located in a sidecar container #13614

Theia can't open files located in a sidecar container #13614

tolusha commented Jun 21, 2019 •

edited

Loading

tolusha commented Aug 6, 2019

tolusha commented Aug 14, 2019

tsmaeder commented Aug 15, 2019

tolusha commented Aug 27, 2019 •

edited

Loading

tsmaeder commented Aug 28, 2019

tolusha commented Aug 28, 2019

tsmaeder commented Aug 28, 2019 •

edited

Loading

tolusha commented Aug 30, 2019

tolusha commented Sep 3, 2019

tsmaeder commented Sep 3, 2019

tsmaeder commented Sep 4, 2019

tsmaeder commented Sep 4, 2019

tolusha commented Sep 18, 2019 •

edited

Loading

Theia can't open files located in a sidecar container #13614

Theia can't open files located in a sidecar container #13614

Comments

tolusha commented Jun 21, 2019 • edited Loading

Description

Reproduction Steps

tolusha commented Aug 6, 2019

tolusha commented Aug 14, 2019

tsmaeder commented Aug 15, 2019

tolusha commented Aug 27, 2019 • edited Loading

tsmaeder commented Aug 28, 2019

tolusha commented Aug 28, 2019

tsmaeder commented Aug 28, 2019 • edited Loading

tolusha commented Aug 30, 2019

tolusha commented Sep 3, 2019

tsmaeder commented Sep 3, 2019

tsmaeder commented Sep 4, 2019

tsmaeder commented Sep 4, 2019

tolusha commented Sep 18, 2019 • edited Loading

tolusha commented Jun 21, 2019 •

edited

Loading

tolusha commented Aug 27, 2019 •

edited

Loading

tsmaeder commented Aug 28, 2019 •

edited

Loading

tolusha commented Sep 18, 2019 •

edited

Loading