Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[omnisharp-plugin] Markdowns are not displayed in the editor #13908

Closed
1 of 3 tasks
svor opened this issue Jul 18, 2019 · 5 comments
Closed
1 of 3 tasks

[omnisharp-plugin] Markdowns are not displayed in the editor #13908

svor opened this issue Jul 18, 2019 · 5 comments
Labels
area/languages Issues related to Language extensions or plugins integration. kind/bug Outline of a bug - must adhere to the bug report template. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.
Milestone

Comments

@svor
Copy link
Contributor

svor commented Jul 18, 2019

Describe the bug

Markdowns are not displayed in the editor for C# files. And if move the cursor to the place where an icon should be I see next error in the browser console:

Exception
Uncaught Error: Cannot read property 'language' of null
TypeError: Cannot read property 'language' of null
    at e.asMarkdownString (vendors.795ac5958e7158cc3edd.js:1)
    at vendors.795ac5958e7158cc3edd.js:1
    at Array.map (<anonymous>)
    at e.asHoverContent (vendors.795ac5958e7158cc3edd.js:1)
    at e.asHover (vendors.795ac5958e7158cc3edd.js:1)
    at vendors.795ac5958e7158cc3edd.js:19
    at async Promise.all (/dashboard/index 0)
    at errors.ts:81

omnisharp plug-in, which provides the functionality of omnisharp language server is here https://github.com/redhat-developer/omnisharp-theia-plugin

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

You can follow steps in the video: https://youtu.be/Zkm513MgBl8

@svor svor added area/languages Issues related to Language extensions or plugins integration. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. kind/bug Outline of a bug - must adhere to the bug report template. labels Jul 18, 2019
@rhopp
Copy link
Contributor

rhopp commented Jul 19, 2019

Triaging the issue the same as it's parent issue. If you think this issue should be triaged for Che 7 GA, speak up ;-)

@rhopp rhopp added this to the 7.1.0 milestone Jul 19, 2019
@slemeur
Copy link
Contributor

slemeur commented Aug 2, 2019

@svor Can you precise what markdowns cannot be displayed and where ?
The issue is a bit obscur to me :)

@svor
Copy link
Contributor Author

svor commented Aug 6, 2019

@slemeur for example QuickFixe icons:
screenshot-localhost_3000-2019 08 06-16_55_42

@svor
Copy link
Contributor Author

svor commented Aug 7, 2019

should be fixed by eclipse-che/che-plugin-registry#199

@svor
Copy link
Contributor Author

svor commented Nov 25, 2019

fixed by eclipse-che/che-plugin-registry#199

@svor svor closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. kind/bug Outline of a bug - must adhere to the bug report template. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.
Projects
None yet
Development

No branches or pull requests

3 participants