Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new version of Omnisharp plugin #199

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Add new version of Omnisharp plugin #199

merged 1 commit into from
Sep 3, 2019

Conversation

svor
Copy link
Contributor

@svor svor commented Aug 7, 2019

Signed-off-by: Valeriy Svydenko vsvydenk@redhat.com

What does this PR do?

Provides new version of Theia Omnisharp plug-in and updates latest version.

This PR should fix a set of issues: eclipse-che/che#13892

Demo: https://youtu.be/Uc6ZS_8vS4w

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are licensing issues to be cleaned up in https://github.com/redhat-developer/omnisharp-theia-plugin/. Until we have those resolved, I'm blocking this PR.

@l0rd
Copy link
Contributor

l0rd commented Aug 22, 2019

Che 7.0.0 has been released. @svor what's the status of this PR?

@tolusha
Copy link
Contributor

tolusha commented Aug 22, 2019

@l0rd It will be merged once eclipse-che/che#14224 is fixed

@tsmaeder tsmaeder dismissed their stale review August 22, 2019 09:00

License issues resolved

@tolusha tolusha changed the title [DON'T MERGE 7.1.0 TARGET] Add new version of Omnisharp plugin Add new version of Omnisharp plugin Aug 22, 2019
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on latest Che and found no significant issues.

@AndrienkoAleksandr
Copy link
Contributor

@tsmaeder @ibuziuk I think it's important for 7.1.0

@ibuziuk
Copy link
Member

ibuziuk commented Sep 2, 2019

@rhopp @l0rd @skabashnyuk we need to get the code owners approvals

@svor
Copy link
Contributor Author

svor commented Sep 3, 2019

quick demo about how it works: https://youtu.be/Futqc4tNGLE

@ibuziuk ibuziuk mentioned this pull request Sep 3, 2019
21 tasks
@ibuziuk
Copy link
Member

ibuziuk commented Sep 3, 2019

I think there are licensing issues to be cleaned up in https://github.com/redhat-developer/omnisharp-theia-plugin/. Until we have those resolved, I'm blocking this PR.

@tsmaeder have licensing issues been tackled already? if this is the case please approve & merge the PR if it is planned for 7.1.0

@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 3, 2019

License issues resolved

@ibuziuk

@l0rd l0rd merged commit 969c538 into master Sep 3, 2019
@apupier
Copy link
Contributor

apupier commented Sep 11, 2019

closing, the commit has been merged directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants