Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug>Start with no debug configurations gives no feedback to the user #14006

Closed
5 tasks done
sparkoo opened this issue Jul 24, 2019 · 9 comments
Closed
5 tasks done

Debug>Start with no debug configurations gives no feedback to the user #14006

sparkoo opened this issue Jul 24, 2019 · 9 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@sparkoo
Copy link
Member

sparkoo commented Jul 24, 2019

Describe the bug

We have several devfiles (https://github.com/eclipse/che-devfile-registry/tree/master/devfiles/angular, https://github.com/eclipse/che-devfile-registry/tree/master/devfiles/dotnet) where there is no option to debug the project. When selecting Debug>Start debuggin (or F5) shortcut, nothing happens. As well as Debug>Start without debugging (Ctrl+F5).

Che version

  • nightly

Steps to reproduce

  1. create workspace from devfile https://github.com/eclipse/che-devfile-registry/tree/master/devfiles/angular
  2. run yarn install task
  3. open main.ts file
  4. click Debug>Start Debugging
  5. nothing happens

Expected behavior

current file should start and debug should work

Runtime

  • minikube (include output of minikube version and kubectl version)

Screenshots

debug

Installation method

  • chectl

Environment

  • my computer
    • Linux

Additional context

@slemeur
Copy link
Contributor

slemeur commented Jul 24, 2019

Is there a debug configuration that is present in your workspace? and is the application started in debug mode?

@slemeur slemeur added status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 24, 2019
@sparkoo
Copy link
Member Author

sparkoo commented Jul 25, 2019

@slemeur There is not. TBH, I didn't know I have to add configuration first. I thought that clicking debug will run and debug current file. Take it as new user might see it.
I would suggest to either disable Debug option, when no configuration. Or maybe better open launch.json in the same way as if I click on Add configuration.
Q: is it possible to add debug configuration to devfile?

@slemeur
Copy link
Contributor

slemeur commented Jul 26, 2019

You are 100 in your approach, to take it as a new user.
I like your proposal of with the debug option when there is no configuration available. The user should be guided into creating at first. Could you create the enhancement issue for that? cc @tolusha .

As for the debug configuration in the devfile, I don't think it is right now, but something we should be looking at.

@gorkem
Copy link
Contributor

gorkem commented Jul 27, 2019

I think we should display a list of installed debuggers on the workspace and auto-generate a launch with the selected one and open the launch.json. It is very likely that auto-generation will not get the all details right but it will provide the starting point.

@tolusha
Copy link
Contributor

tolusha commented Jul 27, 2019

I like your proposal of with the debug option when there is no configuration available. The user should be guided into creating at first. Could you create the enhancement issue for that?

It is how VS Code behaves.

@amisevsk
Copy link
Contributor

amisevsk commented Jul 29, 2019

Currently, clicking "Start Debugging" without a config doesn't do nothing, it just creates a default debug config in the background without notifying the user. Clicking "Start Debugging" a second time opens the debug panel and starts the just-created config. This is a pretty unintuitive flow, even though it sometimes works without issue.

E.g. I just tested the golang devfile:

  • Check debug configs, nothing there
  • Click "Start Debugging", nothing happens
  • Open debug configs, new default entry is added
  • Click "Start Debugging", Debug sidebar is opened and debugging launches.

We should either merge steps the create + launch, or notify the user to create a debug config with a prefilled template.

@amisevsk amisevsk changed the title Debug>Start debugging does not work Debug>Start with no debug configurations gives no feedback to the user Jul 29, 2019
@amisevsk amisevsk added the area/editor/theia Issues related to the che-theia IDE of Che label Jul 29, 2019
@sparkoo
Copy link
Member Author

sparkoo commented Jul 30, 2019

@amisevsk Thank you for investigating and renaming the issue. Makes much more sense now.
I think that create + launch + notify that debug config was generated is the way to go. We should do the best to prepare workspace for debugging, but we can't do magic so it should be clear that the configuration was generated and user is supposed to customize it.

@benoitf benoitf removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@l0rd l0rd added this to the 7.2.0 milestone Aug 2, 2019
@l0rd l0rd added severity/P2 Has a minor but important impact to the usage or development of the system. kind/enhancement A feature request - must adhere to the feature request template. and removed status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. labels Aug 2, 2019
@l0rd
Copy link
Contributor

l0rd commented Aug 2, 2019

Removed status/info-needed as it looks like we have an agreement: generate and open a launch.json file. But not to launch it right away (the user needs to review it first). And if there is more than one DBA prompting the user which one to use.

@gazarenkov gazarenkov removed this from the 7.2.0 milestone Oct 2, 2019
@azatsarynnyy azatsarynnyy mentioned this issue Jan 9, 2020
13 tasks
@vzhukovs vzhukovs self-assigned this Jan 9, 2020
@vzhukovs vzhukovs added the status/in-progress This issue has been taken by an engineer and is under active development. label Jan 9, 2020
@vzhukovs
Copy link
Contributor

vzhukovs commented Jan 15, 2020

Following PR merged in theia upstream: eclipse-theia/theia#6870

@vzhukovs vzhukovs removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

9 participants