Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php-laravel devfile sample should be simplified #14010

Closed
sparkoo opened this issue Jul 24, 2019 · 3 comments
Closed

php-laravel devfile sample should be simplified #14010

sparkoo opened this issue Jul 24, 2019 · 3 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@sparkoo
Copy link
Member

sparkoo commented Jul 24, 2019

Is your task related to a problem? Please describe.

php-laravel devfile (https://github.com/eclipse/che-devfile-registry/tree/master/devfiles/php-laravel) has 6 tasks. To properly run the project, user has to go through README and map individual install steps to tasks and run them one by one.

Describe the solution you'd like

Workflow should be simplified by only one task that prepares project regarding to README instructions. And second task that will run the project.

Describe alternatives you've considered

Additional context
@sparkoo sparkoo added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jul 24, 2019
@sparkoo sparkoo mentioned this issue Jul 24, 2019
Closed
@amisevsk
Copy link
Contributor

+1 for this, when testing this devfile it took more reasoning than it should to prepare the project; it makes more sense to have one "prepare" task. Additionally, running tasks in the wrong order often results in error.

@slemeur
Copy link
Contributor

slemeur commented Jul 24, 2019

Good improvement to add!

@slemeur slemeur added this to the 7.1.0 milestone Jul 24, 2019
@slemeur slemeur added kind/enhancement A feature request - must adhere to the feature request template. team/platform and removed kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jul 24, 2019
@skabashnyuk skabashnyuk added the severity/P2 Has a minor but important impact to the usage or development of the system. label Aug 1, 2019
@slemeur slemeur modified the milestones: 7.1.0, 7.3.0 Aug 2, 2019
@amisevsk amisevsk mentioned this issue Sep 10, 2019
Closed
@skabashnyuk skabashnyuk removed this from the 7.3.0 milestone Sep 19, 2019
@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2020
@che-bot che-bot closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sparkoo @skabashnyuk @slemeur @amisevsk @che-bot