Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github plugin installation fails #14319

Closed
5 of 23 tasks
vinokurig opened this issue Aug 23, 2019 · 3 comments · Fixed by eclipse-theia/theia#6073
Closed
5 of 23 tasks

Github plugin installation fails #14319

vinokurig opened this issue Aug 23, 2019 · 3 comments · Fixed by eclipse-theia/theia#6073
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@vinokurig
Copy link
Contributor

vinokurig commented Aug 23, 2019

Describe the bug

Github plugin installation fails, Git extension fails as well if the GitHub plugin is turned on.
This happens because the GitHub plugin has vscode git extension in it's plugin dependencies. Since eclipse-theia/theia@2d4c845 was merged Theia automatically installs dependent plugins, but the vscode git extension is not located in the vscode marketplace.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Start a workspace with the GitHub plugin turned on.
    WRONG:
    Git plugin doesn't work:
    screenshot-che-che 192 168 39 215 nip io-2019 08 23-10-07-48
    The error is shown in the log console:
root ERROR TypeError: Cannot read property 'versions' of undefined
    at Request._callback (/home/theia/node_modules/@theia/plugin-ext-vscode/lib/node/plugin-vscode-resolver.js:129:55)
    at Request.self.callback (/home/theia/node_modules/request/request.js:185:22)
    at Request.emit (events.js:198:13)
    at Request.<anonymous> (/home/theia/node_modules/request/request.js:1161:10)
    at Request.emit (events.js:198:13)
    at IncomingMessage.<anonymous> (/home/theia/node_modules/request/request.js:1083:12)
    at Object.onceWrapper (events.js:286:20)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1129:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
root ERROR Uncaught Exception:  Error: No extension
root ERROR Error: No extension
    at Request._callback (/home/theia/node_modules/@theia/plugin-ext-vscode/lib/node/plugin-vscode-resolver.js:120:44)
    at Request.self.callback (/home/theia/node_modules/request/request.js:185:22)
    at Request.emit (events.js:198:13)
    at Request.<anonymous> (/home/theia/node_modules/request/request.js:1161:10)
    at Request.emit (events.js:198:13)
    at IncomingMessage.<anonymous> (/home/theia/node_modules/request/request.js:1083:12)
    at Object.onceWrapper (events.js:286:20)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1129:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Expected behavior

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

@vinokurig vinokurig added kind/bug Outline of a bug - must adhere to the bug report template. area/editor/theia Issues related to the che-theia IDE of Che labels Aug 23, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 23, 2019
@tolusha
Copy link
Contributor

tolusha commented Aug 23, 2019

eclipse-theia/theia#5993

@ibuziuk ibuziuk removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 26, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Aug 26, 2019

@vinokurig removing need-triage label, please set a milestone based on the team priorities

@ibuziuk
Copy link
Member

ibuziuk commented Aug 26, 2019

oh, looks like it is part of #14295 - moving to 7.2.0

@ibuziuk ibuziuk added this to the 7.2.0 milestone Aug 26, 2019
@l0rd l0rd added the severity/P1 Has a major impact to usage or development of the system. label Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants