Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kubeconfig injection with chectl #14877

Closed
1 of 3 tasks
l0rd opened this issue Oct 14, 2019 · 6 comments
Closed
1 of 3 tasks

Improve kubeconfig injection with chectl #14877

l0rd opened this issue Oct 14, 2019 · 6 comments
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Oct 14, 2019

Is your enhancement related to a problem? Please describe.

A working Kubernetes config is something that users will expect in a Che workspace but the UX is still not perfect:

  • A user cannot specify the particular kubernetes context (cluster, namespace and user) should be injectected.
  • Starting a workspace with the local kubeconfig requires to run 2 commands (workspace start+inject) when it could be one command only.
  • If a workspace is stopped and restarted the injected local kubeconfig will get lost.

Describe the solution you'd like

  • Add the parameter --context to the workspace:inject command. It will be used to specify the context to be injected. If no --context parameter is provided only the current context will be injected.
  • Add two new parameter --inject-context <> and --inject-current-context to the workspace:start command. Since the workspace:start command currently doesn't start a workspace (it only creates it), to inject the we should probably add init containers that will generate the kube config, create a secret with the user token and a config map with the other context details.
  • Modify workspace:inject to use the init container approach mentioned above.
@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. area/chectl Issues related to chectl, the CLI of Che labels Oct 14, 2019
@l0rd
Copy link
Contributor Author

l0rd commented Oct 14, 2019

cc @kameshsampath

@l0rd l0rd changed the title Improve workspace:inject command Improve kubeconfig injection with chectl Oct 14, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 14, 2019
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. team/devex and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 14, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Oct 14, 2019

@l0rd not sure about priority, but I put P1 for now, since having a neat kubeconfig support looks pretty important for kubenative IDE

@l0rd
Copy link
Contributor Author

l0rd commented Oct 14, 2019

I confirm this should be a P1

@azatsarynnyy
Copy link
Member

PR for --context parameter che-incubator/chectl#430

@l0rd l0rd removed the team/ide label Dec 12, 2019
@azatsarynnyy azatsarynnyy mentioned this issue Dec 19, 2019
8 tasks
@tolusha tolusha modified the milestones: 7.6.0, Backlog - Deploy Feb 17, 2020
@tolusha tolusha modified the milestone: Backlog - Deploy May 6, 2020
@tolusha tolusha removed this from the Backlog - Deploy milestone May 7, 2020
@che-bot
Copy link
Contributor

che-bot commented Jan 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Jan 4, 2021

Closing this issue as today we have a mechanism to pre-create secrets that will be automatically mounted in workspaces containers.

@l0rd l0rd closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants