Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShift Connector for Eclipse Che #14900

Closed
2 of 3 tasks
slemeur opened this issue Oct 16, 2019 · 8 comments
Closed
2 of 3 tasks

OpenShift Connector for Eclipse Che #14900

slemeur opened this issue Oct 16, 2019 · 8 comments
Labels
area/chectl Issues related to chectl, the CLI of Che kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@slemeur
Copy link
Contributor

slemeur commented Oct 16, 2019

Goal

The goal of this epic is to finalize the work that has been done on getting the VSCode OpenShift connector extension available to Che users.

Target User

Developers using Eclipse Che

Target environments

  • Eclipse Che
  • Hosted Che

Context

As a developer using Eclipse Che, I should be able to interact with an OpenShift cluster without using a command-line tool, so that I can easily explore an existing cluster, create new namespace and deploy applications.

Problem

Configuring and using the openshift connector plugin in the context of Eclipse Che is hard.

  • In order to get the OpenShift Connector plugin working, the user needs to also enable the Kubernetes Plugin and the YAML Plugin. But as a user, I have no way to understand those dependencies.
  • Eclipse Che can be deployed on an OpenShift Cluster. Depending on the configuration the user should already be connected on the cluster.
  • The plugin is not part of any test suites. Regressions are easily getting introduced.
  • The plugin should be usable on OCP 3.11, OCP 4.x and tested on various environment like Hosted Che, CRC, OSD
  • There are certain commands which are not compatible (or not making sense) in the context of Eclipse Che, example: Watch.

As an admin I should also be able to configure the OpenShift Connector to be available by default with all workspaces so that the developers don't have to manage that configuration in their workspaces.

Solutions

Inject the user Kubernetes cluster context in the workspace containers

  • Automatically if the user is authenticated using OpenShift OAuth
  • Using chectl workspace:start otherwise

Add test suites for the plugin
Include a Kubernetes tooling scenario in the happy path test (PR check)
Include an OpenShift connector scenario in the nightly CI

Validate the plugin on the different targeted platform of Che
(OCP 3.11, OCP 4.x and tested on various environment like Hosted Che, CRC, OSD)

Add admin configuration option to enable the plugin into all workspaces

Restarting the workspace should maintain the cluster configuration: When a user configure access to some clusters, those information are not persisted. If user restarts the workspace the configuration will need to be done once again

Sub-tasks

@slemeur slemeur added the kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. label Oct 16, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 16, 2019
@benoitf benoitf added this to the Backlog - IDE 1 milestone Oct 16, 2019
@benoitf benoitf added severity/P1 Has a major impact to usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 16, 2019
@azatsarynnyy
Copy link
Member

In order to get the OpenShift Connector plugin working, the user needs to also enable the Kubernetes Plugin and the YAML Plugin. But as a user, I have no way to understand those dependencies

That has been improved for almost 5 months ago.
Currently, the user doesn't need to understand those dependencies and he/she even couldn't know about them. The dependent plugins are installed automatically in the same way as in VS Code.
Thanks to Josh's PR eclipse-theia/theia#5379
@slemeur could you please provide some use case when the problem is still reproducible? It would help to diagnose it.

@azatsarynnyy
Copy link
Member

There are certain commands which are not compatible (or not making sense) in the context of Eclipse Che, example: Watch

Watch command is very helpful for updating a component on change.
Sorry, I can't understand why some commands are not making sense in Che.
@slemeur could you please clarify?

@slemeur
Copy link
Contributor Author

slemeur commented Nov 4, 2019

@azatsarynnyy : In the context of Che, in which situation would you prefer to do a watch from running the code source in your workspace?

Watch allows to track changes in the local source code (inside of the workspace) and update the component that it is related to. That component could be outside of the workspace - so that's interesting. But watch mostly focus on fastening the inner-loop. In the context of Che, isn't it faster to run it as part of the workspace?

@azatsarynnyy
Copy link
Member

isn't it faster to run it as part of the workspace?

if one runs everything inside the workspace, why he/she could require OpenShift plugin then?
I guess I misunderstand something.

@benoitf benoitf added team/plugins area/plugins and removed area/editor/theia Issues related to the che-theia IDE of Che labels Jan 7, 2020
@ericwill ericwill mentioned this issue Jan 8, 2020
16 tasks
@l0rd
Copy link
Contributor

l0rd commented Jan 21, 2020

Related to #15261 and #15670

@ericwill ericwill mentioned this issue Jan 28, 2020
12 tasks
@ericwill ericwill mentioned this issue Feb 19, 2020
21 tasks
@ericwill ericwill mentioned this issue Mar 12, 2020
50 tasks
@ericwill ericwill mentioned this issue Apr 1, 2020
47 tasks
@ericwill
Copy link
Contributor

All the plugins related items from this epic are complete, only the chectl item(s) remain.

@ericwill ericwill removed this from the Backlog - IDE 1 milestone Apr 28, 2020
@ericwill ericwill added area/chectl Issues related to chectl, the CLI of Che and removed area/plugins team/plugins labels Apr 28, 2020
@tolusha
Copy link
Contributor

tolusha commented Apr 30, 2020

@ericwill
We will try to take remaining issue in the next sprint.

@che-bot
Copy link
Contributor

che-bot commented Oct 28, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 28, 2020
@che-bot che-bot closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

7 participants