Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactoring] Improve consistency in defaults.go variables #14957

Closed
nickboldt opened this issue Oct 22, 2019 · 1 comment
Closed

[refactoring] Improve consistency in defaults.go variables #14957

nickboldt opened this issue Oct 22, 2019 · 1 comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/technical-debt Technical debt issue severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Oct 22, 2019 •
edited by l0rd
Loading

In defaults.go at L23-L26 we use "CodeReady" as if it's a product to differentiate from "Che".

But at L36-L52 we use the "Upstream" convention to differentiate Che from CRW config.

This is bad code smell but not technically a problem, so should be dealt with when we're bored in the future and ready for some refactoring.
@nickboldt nickboldt added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 22, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 22, 2019
@l0rd l0rd added the area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator label Oct 23, 2019
@l0rd l0rd changed the title [operator] [refactoring] Improve consistency in defaults.go variables [refactoring] Improve consistency in defaults.go variables Oct 23, 2019
@l0rd l0rd added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 23, 2019
@davidfestal davidfestal added kind/technical-debt Technical debt issue and removed kind/enhancement A feature request - must adhere to the feature request template. labels Nov 6, 2019
@tolusha
Copy link
Contributor

tolusha commented Feb 17, 2020

eclipse-che/che-operator#172
It n't relevant any more

@tolusha tolusha closed this as completed Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/technical-debt Technical debt issue severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nickboldt @l0rd @davidfestal @tolusha @che-bot