Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use top-level readme if available when opening workspace #15080

Closed
apupier opened this issue Nov 4, 2019 · 13 comments
Closed

Use top-level readme if available when opening workspace #15080

apupier opened this issue Nov 4, 2019 · 13 comments
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@apupier
Copy link
Contributor

apupier commented Nov 4, 2019 •
edited
Loading

Is your enhancement related to a problem? Please describe.

currently it is taking one readme that can be in subfolders.

Describe the solution you'd like

Preference to take the top-level readme

Describe alternatives you've considered

Additional context

when using Camel K examples subfolder from the stack in preparation #14831 , it is opening https://github.com/apache/camel-k/blob/master/examples/tekton/README.md instead of top-level one of examples folder https://github.com/apache/camel-k/blob/master/examples/Readme.md
@apupier apupier added the kind/enhancement A feature request - must adhere to the feature request template. label Nov 4, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 4, 2019
@benoitf benoitf added the area/editor/theia Issues related to the che-theia IDE of Che label Nov 4, 2019
@benoitf
Copy link
Contributor

benoitf commented Nov 4, 2019

I think it's because at the beginning VS Code API implementation of search was not implemented so had to use workarounds. (thus leading to invalid expected behaviour)

@apupier
Copy link
Contributor Author

apupier commented Nov 4, 2019 •
edited
Loading

wondering also if it is because it is case sensitive for the readme file

https://github.com/eclipse/che-theia/blob/846f13e2a139f24a2f9361cfefc084d8843efb37/plugins/welcome-plugin/src/welcome-plugin.ts#L59

@ibuziuk ibuziuk added severity/P2 Has a minor but important impact to the usage or development of the system. team/ide2 and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 4, 2019
@apupier apupier mentioned this issue Nov 28, 2019
Merged
@azatsarynnyy azatsarynnyy added area/plugins and removed area/editor/theia Issues related to the che-theia IDE of Che team/editors labels Feb 6, 2020
@azatsarynnyy
Copy link
Member

labeled as area/plugins as related to https://github.com/eclipse/che-theia/tree/master/plugins/welcome-plugin

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2020
@apupier
Copy link
Contributor Author

apupier commented Aug 21, 2020

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2020
@guydog28
Copy link

guydog28 commented Sep 1, 2020

This is a problem for us. Developers are taken to a README.md located in a sub folder that was the "pre-che" workspace set up and use instructions, instead of the new Che-based setup and use instructions at the ROOT, which is quite confusing.

@che-bot
Copy link
Contributor

che-bot commented Mar 17, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@apupier
Copy link
Contributor Author

apupier commented Mar 17, 2021

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@che-bot
Copy link
Contributor

che-bot commented Sep 20, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2021
@apupier
Copy link
Contributor Author

apupier commented Sep 20, 2021

/remove-lifecycle stale

@benoitf benoitf removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2021
@che-bot
Copy link
Contributor

che-bot commented Mar 19, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 19, 2022
@guydog28
Copy link

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 19, 2022
@che-bot
Copy link
Contributor

che-bot commented Sep 15, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2022
@che-bot che-bot closed this as completed Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@benoitf @apupier @ibuziuk @azatsarynnyy @guydog28 @che-bot