Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openshift plugin] improve cluster login flow when Che is on non-secure connection #15093

Closed
azatsarynnyy opened this issue Nov 5, 2019 · 1 comment · Fixed by eclipse-theia/theia#6516
Closed

[openshift plugin] improve cluster login flow when Che is on non-secure connection #15093

azatsarynnyy opened this issue Nov 5, 2019 · 1 comment · Fixed by eclipse-theia/theia#6516
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.5.0

Comments

@azatsarynnyy
Copy link
Member

Is your task related to a problem? Please describe.

OpenShift Connector Che Plugin provides the commands to log in to a cluster through the Theia commands palette. It works well when Che is on https connection only.
When on http, it reports
image

More details:
It's because plugin's Log in commands are relying on VS Code Clipboard API which is implemented with browser's navigator.clipboard API in Theia. For the security reasons, navigator.clipboard API works on secure connections only.

So, the user needs to log in from a terminal with the oc login command.

Describe the solution you'd like

It would be great to allow the user to log in to a cluster with Theia UI w/o using a terminal.
For example, when I'm running Che on CodeReady Containers, it's running on http.

Describe alternatives you've considered

Additional context
@azatsarynnyy azatsarynnyy added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Nov 5, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 5, 2019
@azatsarynnyy azatsarynnyy changed the title [openshift plugin] improve cluster login flow when Che is on non secure connection [openshift plugin] improve cluster login flow when Che is on non-secure connection Nov 5, 2019
@slemeur slemeur mentioned this issue Nov 5, 2019
Closed
3 tasks
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. team/ide and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 5, 2019
@vparfonov vparfonov added this to the Backlog - IDE 1 milestone Nov 6, 2019
@vparfonov vparfonov mentioned this issue Nov 6, 2019
Closed
19 tasks
@azatsarynnyy azatsarynnyy mentioned this issue Nov 8, 2019
Merged
1 task
@vparfonov vparfonov modified the milestones: Backlog - IDE 1, 7.5.0 Nov 11, 2019
@azatsarynnyy
Copy link
Member Author

Fixed in Theia upstream by eclipse-theia/theia#6516
The patch will be available in Che Theia after switching to the next Theia release, probably 0.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.5.0
Development

Successfully merging a pull request may close this issue.

Don't throw an error if access to the clipboard is denied. eclipse-theia/theia
4 participants
@l0rd @azatsarynnyy @vparfonov @che-bot