Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[che-operator] - enable che-server tracing #15213

Closed
sparkoo opened this issue Nov 18, 2019 · 2 comments
Closed

[che-operator] - enable che-server tracing #15213

sparkoo opened this issue Nov 18, 2019 · 2 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@sparkoo
Copy link
Member

sparkoo commented Nov 18, 2019

Is your enhancement related to a problem? Please describe.

Task of this epic #15046
To support tracing, we need to make it possible to enable and configure tracing of che server from che-operator.

Describe the solution you'd like

On che-server, tracing is configured with several options https://www.eclipse.org/che/docs/che-7/tracing-che/. The minimal values we need to set are CHE_TRACING_ENABLED and JAEGER_ENDPOINT.
For that, we will update CheCluster CRD with:

tracing:
  enable: # default false
  jaegerClientConfig:	# optional
    serviceName:"che-server"
    endpoint: "http://jaeger-collector:14268/api/traces"	# endpoint is mandatory for external jaeger
    sampler:
      managerHostPort: "jaeger:5778"
      type:"const"
      param:"1"
    reporter:
      maxQueueSize: "10000"

If tracing.enable:true enable che-server tracing and set other tracing config values as set in tracing.jaegerClientConfig with defaults https://www.eclipse.org/che/docs/che-7/tracing-che/

Set the default value of tracing.jaegerClientConfig.endpoint to instance we will create in our own namespace (#15214). In case of external Jaeger, It must be set to jaeger-collector service endpoint (http://.:14268/api/traces) -> JAEGER_ENDPOINT="http://<jaeger-collector-servicename>.<jaeger-namespace>:14268/api/traces".

Additional context

epic: #15046
analysis: #15136 proposal v3 #15136 (comment)

@sparkoo sparkoo added kind/enhancement A feature request - must adhere to the feature request template. team/platform severity/P1 Has a major impact to usage or development of the system. labels Nov 18, 2019
@skabashnyuk skabashnyuk added this to the Backlog - Platform milestone Nov 18, 2019
@sparkoo sparkoo added the area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator label Nov 25, 2019
@che-bot
Copy link
Contributor

che-bot commented May 27, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2020
@sparkoo sparkoo removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2020
@che-bot
Copy link
Contributor

che-bot commented Jan 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021
@che-bot che-bot closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants