Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to have multiple endpoints with the same port and protocol for CheEditor #15410

Closed
skabashnyuk opened this issue Dec 5, 2019 · 4 comments
Closed

Allow to have multiple endpoints with the same port and protocol for CheEditor #15410

skabashnyuk opened this issue Dec 5, 2019 · 4 comments
Assignees
@metlos
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone
7.8.0

Comments

@skabashnyuk
Copy link
Contributor

Is your task related to a problem? Please describe.

There is a change in Theia that might require this kind of separation. See #15283 (comment)

Describe the solution you'd like

multiple endpoints with the same port and protocol for CheEditor will generate multiple routes that are pointed to the same port.

Describe alternatives you've considered

n/a

Additional context

n/a
@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform labels Dec 5, 2019
@skabashnyuk skabashnyuk added this to the 7.6.0 milestone Dec 5, 2019
@skabashnyuk skabashnyuk mentioned this issue Dec 5, 2019
Closed
9 tasks
@mmorhun
Copy link
Contributor

mmorhun commented Dec 5, 2019

Also we need to have the same for Hosted Instance.

@skabashnyuk
Copy link
Contributor Author

Also we need to have the same for Hosted Instance.

Maybe a bit later. This task is not yet considered production-ready. For now, this is just a POC. We need to fully understand the pros and cons of this feature.

@metlos metlos mentioned this issue Dec 11, 2019
Merged
@skabashnyuk skabashnyuk modified the milestones: 7.6.0, 7.7.0 Dec 18, 2019
@skabashnyuk skabashnyuk changed the title [POC] Allow to have multiple endpoints with the same port and protocol for CheEditor Allow to have multiple endpoints with the same port and protocol for CheEditor Dec 18, 2019
@l0rd
Copy link
Contributor

l0rd commented Dec 18, 2019

That's required to support single/default host mode with the new Theia webview right?

@skabashnyuk
Copy link
Contributor Author

@l0rd yes it's related to Theia webview.

@skabashnyuk skabashnyuk modified the milestones: 7.7.0, 7.8.0 Jan 7, 2020
@skabashnyuk skabashnyuk mentioned this issue Jan 22, 2020
Closed
@metlos metlos closed this as completed Jan 29, 2020
@amisevsk amisevsk mentioned this issue Feb 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metlos metlos

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.8.0
Development

No branches or pull requests
4 participants
@metlos @l0rd @skabashnyuk @mmorhun