Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin and devfile registry will fail to build if any line ends in tab character #15507

Open
amisevsk opened this issue Dec 17, 2019 · 3 comments
Open

Plugin and devfile registry will fail to build if any line ends in tab character #15507

amisevsk opened this issue Dec 17, 2019 · 3 comments
Labels
area/devfile-registry area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@amisevsk
Copy link
Contributor

amisevsk commented Dec 17, 2019 •
edited
Loading

Describe the bug

Due to an open issue with PyYAML (which is the main dependency of yq), any yaml files in registries that end in tab characters will cause builds to fail.

Expected behavior

The yaml reference parser does not have an issue with trailing tabs, so this appears to be a PyYAML issue, but it's probably good practice to avoid trailing whitespace in meta.yamls anyways. It would be great to have a linter of some sort check for e.g. 1) file ends in newline and 2) no trailing whitespace on PRs.

Additional context

See #15483 for our initial encounter with the issue.
@amisevsk amisevsk added kind/bug Outline of a bug - must adhere to the bug report template. area/devfile-registry area/plugin-registry labels Dec 17, 2019
@amisevsk amisevsk mentioned this issue Dec 17, 2019
Closed
3 tasks
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 17, 2019
@l0rd
Copy link
Contributor

l0rd commented Dec 17, 2019

Maybe https://stickler-ci.com/?

@l0rd l0rd added severity/P2 Has a minor but important impact to the usage or development of the system. team/plugins and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 17, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2020
@ericwill
Copy link
Contributor

👍 this should be part of PR checks for the registries.

@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/devfile-registry area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nickboldt @l0rd @ericwill @amisevsk @che-bot