Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build the offline-registry image of che-devfile-registry / offline-registry. #15483

Closed
1 of 3 tasks
monaka opened this issue Dec 15, 2019 · 6 comments · Fixed by eclipse-che/che-devfile-registry#167
Closed
1 of 3 tasks
Assignees
Labels
area/devfile-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach

Comments

@monaka
Copy link
Member

monaka commented Dec 15, 2019

Describe the bug

Docker builds ware stopped in the offline-builder phase.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Run docker build --no-cache -t quay.io/eclipse/che-devfile-registry:nightly -f build/dockerfiles/Dockerfile .
  2. See error
Caching project files for devfile devfiles/java-mysql/devfile.yaml
yq: Error running jq: ScannerError: while scanning for the next token
found character '\t' that cannot start any token
  in "devfiles/java-mysql/devfile.yaml", line 21, column 27.
The command '/bin/sh -c ./cache_projects.sh devfiles resources &&     ./cache_images.sh devfiles resources &&     chmod -R g+rwX /build' returned a non-zero code: 1

Expected behavior

Builds finished with no error.

Additional context

I've already fixed it. I'm going to send PR.

@monaka monaka added the kind/bug Outline of a bug - must adhere to the bug report template. label Dec 15, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 15, 2019
monaka added a commit to eclipse-che/che-devfile-registry that referenced this issue Dec 15, 2019
fixes eclipse-che/che#15483.

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
@monaka
Copy link
Member Author

monaka commented Dec 15, 2019

I suppose it's better to try building offline images on CI.

@ibuziuk ibuziuk added area/devfile-registry status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 16, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Dec 16, 2019

@amisevsk could you please take a look ?

@amisevsk
Copy link
Contributor

The tab chars slipped past us in PR eclipse-che/che-devfile-registry#160

I'll have to look into the yq error we're seeing here, as this build should not fail for something so simple.

The reason we're not building the offline registry in CI at the moment is that some of the projects referenced in devfiles do not have any license attached, so redistributing this code is a little problematic. See #14790 for more discussion.

@amisevsk
Copy link
Contributor

There is still an outstanding issue to add CircleCI for the devfile registry (#14867) as we have for plugin registry; I haven't had time to set it up yet.

@ibuziuk ibuziuk added the severity/P1 Has a major impact to usage or development of the system. label Dec 16, 2019
monaka added a commit to eclipse-che/che-devfile-registry that referenced this issue Dec 16, 2019
fixes eclipse-che/che#15483.

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
@amisevsk
Copy link
Contributor

To follow up on this, PyYAML as an open bug where trailing tab characters on a line fail to parse: yaml/pyyaml#306

@amisevsk
Copy link
Contributor

Opened #15507 to track the trailing whitespace issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants