Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to get OpenShift oauth token from theia IDE container #15670

Closed
vinokurig opened this issue Jan 13, 2020 · 4 comments · Fixed by #15963
Closed

Make it possible to get OpenShift oauth token from theia IDE container #15670

vinokurig opened this issue Jan 13, 2020 · 4 comments · Fixed by #15963
Assignees
@vinokurig
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.

Comments

@vinokurig
Copy link
Contributor

Is your task related to a problem? Please describe.

We need an OpenShift authentication token to inject it to Openshift connector plugin if Che is started on OpenShift.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@vinokurig vinokurig added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jan 13, 2020
@vinokurig vinokurig mentioned this issue Jan 13, 2020
Closed
@ibuziuk
Copy link
Member

ibuziuk commented Jan 13, 2020

@vinokurig please add the right priority according to the plugins team planning

@skabashnyuk
Copy link
Contributor

I think we should be really careful with OS token. It provides to much power.
It makes sense to wait for #15651 first after that provide token only in a workspace that is not shared until we have some clarification from #15304. Or ideally, that should not be an automated process that adding something by default, instead the user has to do some explicit actions that confirm his intention to inject OS tokens into his workspace.

@vinokurig
Copy link
Contributor Author

@ibuziuk I think this issue is not in the scope of the plugins team responsibilities. The issue is about providing authorisation token. @l0rd @benoitf WDYT?

@l0rd l0rd mentioned this issue Jan 21, 2020
Closed
3 tasks
@vinokurig
Copy link
Contributor Author

I think adding an OAuthAuthenticator implementation for Open-Shift will help @skabashnyuk WDYT?

@ericwill ericwill mentioned this issue Jan 28, 2020
Closed
12 tasks
@vinokurig vinokurig added the status/in-progress This issue has been taken by an engineer and is under active development. label Jan 31, 2020
@vinokurig vinokurig self-assigned this Jan 31, 2020
@vinokurig vinokurig mentioned this issue Feb 7, 2020
Merged
@vinokurig vinokurig added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Feb 10, 2020
@ericwill ericwill mentioned this issue Feb 19, 2020
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply OpenShift OAuth provider eclipse-che/che
3 participants
@ibuziuk @skabashnyuk @vinokurig