Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task install dependencies failing in PHP Symfony #15854

Closed
Katka92 opened this issue Jan 28, 2020 · 8 comments
Closed

Task install dependencies failing in PHP Symfony #15854

Katka92 opened this issue Jan 28, 2020 · 8 comments
Labels
area/devfile-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@Katka92
Copy link
Contributor

Katka92 commented Jan 28, 2020 •
edited by l0rd
Loading

Describe the bug

The task Install dependencies is failing in PHP Symfony workspace. The error is:

 Fatal Error: composer.lock was created for PHP version 7.2.9 or higher but the current PHP version is 7.1.29.

Che version

7.7.1b

Steps to reproduce

  1. Log in to che.openshift.io
  2. Go to Workspace -> Add Workspace
  3. Select PHP Symfony stack
  4. Run workspace with the default settings
  5. Run task Install dependencies

Expected behavior

The dependencies should be installed.

Runtime

https://che.openshift.io

Screenshots

Screenshot from 2020-01-28 14-55-13
@Katka92 Katka92 added the kind/bug Outline of a bug - must adhere to the bug report template. label Jan 28, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 28, 2020
@l0rd l0rd added area/devfile-registry team/languages severity/P1 Has a major impact to usage or development of the system. labels Jan 28, 2020
@tolusha tolusha removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 31, 2020
@tsmaeder tsmaeder mentioned this issue Feb 19, 2020
Closed
34 tasks
@tsmaeder
Copy link
Contributor

I guess this is a case where we use "master" of the example and the prereqs no longer fit our stack.

@tsmaeder
Copy link
Contributor

The quick fix is to find an older commit where the build still works. We ran into problems updating the PHP tooling in the past.

@JPinkney
Copy link
Contributor

From my investigations pinning it to the last commit before the project requires a newer version of PHP doesn't work because symphony will report security errors and refuses to build?/finish correctly.

There is a PR on che-dockerfiles open to update to PHP 7.4 but the user still has to sign the eclipse contributor agreement.

I've built the image from that PR and tried it out and was able to successfully get install dependencies working

@JPinkney JPinkney mentioned this issue Mar 3, 2020
Merged
@JPinkney
Copy link
Contributor

JPinkney commented Mar 5, 2020

We've merged the PHP 7.4 update: eclipse-che/che-dockerfiles#253 but I can't find who's responsible for that repo so that we can get it released

@ericwill ericwill mentioned this issue Mar 12, 2020
Closed
50 tasks
@ericwill
Copy link
Contributor

We've merged the PHP 7.4 update: eclipse/che-dockerfiles#253 but I can't find who's responsible for that repo so that we can get it released

It seems that repo is no longer used. The base image for the PHP devfile needs to be updated. Ideally it should use the upstream image as a base.

@JPinkney
Copy link
Contributor

IIRC @amisevsk said we aren't using the upstream php image because there was some incompatibilities or something like that. Otherwise it would have been updated a long time ago

@ericwill
Copy link
Contributor

Okay, I'll investigate.

ericwill added a commit to ericwill/che-php-base that referenced this issue Mar 25, 2020
@ericwill
Initial contribution of the base PHP Dockerfile
4b6f8d0 
This Dockerfile is responsible for the base PHP image
which will be used in the che-devfile-registry.

It is not sufficient to use the plain upstream PHP
image, so we add some customizations necessary for
all the PHP workflows we support.

See eclipse-che/che#15854

Signed-off-by: Eric Williams <ericwill@redhat.com>
This was referenced Mar 25, 2020
Merged
Merged
ericwill added a commit to che-dockerfiles/che-php-base that referenced this issue Mar 26, 2020
@ericwill
Initial contribution of the base PHP Dockerfile (#1)
8de402c 
This Dockerfile is responsible for the base PHP image
which will be used in the che-devfile-registry.

It is not sufficient to use the plain upstream PHP
image, so we add some customizations necessary for
all the PHP workflows we support.

See eclipse-che/che#15854

Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill added a commit to eclipse-che/che-devfile-registry that referenced this issue Mar 27, 2020
@ericwill
Update base image for PHP to that which is located (#217)
106e5bb 
in che-dockerfiles/che-php-base.

See eclipse-che/che#15854

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill
Copy link
Contributor

Closing this, the PHP devfile uses a different base image now which has the updated version of PHP 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/devfile-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@l0rd @tolusha @ericwill @JPinkney @tsmaeder @Katka92 @che-bot