Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che-theia doesn't inform che-master about activity in workspace when https with self-signed cert is used #15991

Closed
5 of 23 tasks
skabashnyuk opened this issue Feb 12, 2020 · 5 comments · Fixed by eclipse-che/che-theia#686
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Feb 12, 2020

Describe the bug

Che-theia doesn't inform che-master about activity in the workspace when https with self-signed cert is used.
I assume the reason is that https://github.com/eclipse/che-theia/blob/master/extensions/eclipse-che-theia-activity-tracker/src/node/activity-tracker-service.ts#L68-L90 is not covering usecase with a self-signed cert.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Setup Che chectl server:start --platform=crc --installer=operator --tls --self-signed-cert
  2. Start workspace.
  3. Workspace would be stopped with default timeout no matter what you are doing inside of it.

Expected behavior

Che-theia should send activity reports to che-master

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl chectl/0.0.20200211-next.1744186 darwin-x64 node-v10.19.0
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

@skabashnyuk skabashnyuk added kind/bug Outline of a bug - must adhere to the bug report template. area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system. labels Feb 12, 2020
@benoitf benoitf changed the title Che-thia doesn't inform che-master about activity in https with self-signed cert is used Che-theia doesn't inform che-master about activity in https with self-signed cert is used Feb 12, 2020
@skabashnyuk skabashnyuk changed the title Che-theia doesn't inform che-master about activity in https with self-signed cert is used Che-theia doesn't inform che-master about activity in workspace when https with self-signed cert is used Feb 12, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Feb 12, 2020
20 tasks
@tsmaeder
Copy link
Contributor

Not sure how the referenced code relates to self-signed certs. Wouldn't that involve manipulating the trust store of the API client somehow?

@skabashnyuk
Copy link
Contributor Author

@l0rd
Copy link
Contributor

l0rd commented Feb 27, 2020

@azatsarynnyy what's the status of this? You had included it in last sprint but not in current one. That looks critical since most of the install are with https and self signed certs now.

@azatsarynnyy
Copy link
Member

@l0rd last sprint we investigated it a bit with @skabashnyuk
We will take it to the next sprint.

@vitaliy-guliy
Copy link
Contributor

It's very annoying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants