Theia terminal extension must propagate error from che-machine-exec

[sleshchenko]

Describe the bug

After something went wrong with my workspace (f?url=https://github.com/eclipse/che-dashboard) I got Theia with empty tabs for tasks and terminal. Refreshing a page does not help.
Empty tabs make impression that terminal/tasks are loading but actually they failed, if I check websocket connections I have the following errors:

Che version

• latest
• nightly
• other: please specify

Steps to reproduce

It can't be reproduced stable but I got it after.

1. Create che-dashboard workspace: f?url=https://github.com/eclipse/che-dashboard
2. Start a terminal
3. Start Install Dependencies task and wait until it's finished.
4. Start Build task.
   Actual behavior: Build task is empty forever, it's not possible to use already initialized terminal.

Expected behavior

The progress of Build task is shown. It's possible to use already initialized terminal.
Or at least theia propagates errors which happens during communication with che-machine-exec via websockets.

Runtime

• kubernetes (include output of kubectl version)
• Openshift (include output of oc version)
• minikube (include output of minikube version and kubectl version)
• minishift (include output of minishift version and oc version)
• crc 1.8.0+0a318dc
• docker-desktop + K8S (include output of docker version and kubectl version)
• other: (please specify)

Screenshots

Installation method

• chectl server:start --chenamespace=vetal --che-operator-cr-patch-yaml ~/che-single-user.yaml --platform=openshift --installer=operator
  where che-single-user.yaml is

spec:
  server:
    selfSignedCert: false
    tlsSupport: false
    customCheProperties:
      CHE_MULTIUSER: "false"
      CHE_LIMITS_USER_WORKSPACES_RAM: "-1"
      CHE_LIMITS_WORKSPACE_IDLE_TIMEOUT: "-1"
      CHE_LOGGER_CONFIG: "export CHE_LOGGER_CONFIG=org.eclipse.che.api.workspace=DEBUG,org.eclipse.che.workspace.infrastructure.kubernetes=DEBUG,org.eclipse.che.workspace.infrastructure.openshift=DEBUG"

• che-operator
• minishift-addon
• I don't know

Environment

• my computer
  • Windows
  • Linux
  • macOS
• Cloud
  • Amazon
  • Azure
  • GCE
  • other (please specify)
• other: please specify

Eclipse Che Logs

Additional context

[che-bot]

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

[sleshchenko]

/remove-lifecycle stale

[sleshchenko]

That should be pretty easy fix(websocket already has error message, it just needs to be displayed) but that's so confusing. So, set P1

[azatsarynnyy]

We've discussed it with @AndrienkoAleksandr. And it is not clear ATM if it's the problem on Che-Theia side or on machine-exec side. Che-Theia already has an error watcher https://github.com/eclipse/che-theia/blob/9a76d18382e3b90858b1fd63e713eb908facbb70/extensions/eclipse-che-theia-terminal/src/browser/terminal-widget/remote-terminal-widget.ts#L109
So, it requires more investigation on the machine-exec side first.

[tolusha]

we are waiting for a release of https://github.com/kubernetes/client-go which is expected to be soon
kubernetes/api#36

[tolusha]

Switching to a new go client fixes the problem
eclipse-che/che-machine-exec#148

[sleshchenko]

That's awesome if it's true 🎉
I'll let you know if I face it again.