Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status marker for vs code tasks is not displayed #16672

Closed
5 of 23 tasks
RomanNikitenko opened this issue Apr 20, 2020 · 1 comment
Closed
5 of 23 tasks

Status marker for vs code tasks is not displayed #16672

RomanNikitenko opened this issue Apr 20, 2020 · 1 comment
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@RomanNikitenko
Copy link
Member

Describe the bug

Status marker for vs code/theia tasks is not displayed due to upstream changes.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Run a vs code task (npm or typescript, for example)
  2. Wait till a task is completed or terminate this one.
  3. Pay attention on a terminal tab for the task: it doesn't contain the corresponding status marker.

Please see a short video and pay attention on the difference between che and vs code tasks behavior.

Expected behavior

Terminal tab contains the corresponding status marker when a vs code task is completed.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

task_status

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify
@RomanNikitenko RomanNikitenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Apr 20, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 20, 2020
@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Apr 20, 2020

The cause of the problem is the corresponding terminal widget can not be found due to upstream changes.
Please take into account that now theia reuses terminal widgets, so without fixing #15742 user will face with the behavior like:

  • running a vs code task
  • the corresponding marker is set to terminal widget when the task is completed
  • run another vs code task ---> theia reuses terminal widget for completed task ---> task is running, but the terminal widget has a status marker from a previous task.

task_status_without_loading

Fixing #15742 will help at this step set in progress status and avoid confusing behavior.

So, I believe this issue depends on #15742

@ericwill ericwill added area/editor/theia Issues related to the che-theia IDE of Che severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 20, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Apr 23, 2020
10 tasks
@RomanNikitenko RomanNikitenko self-assigned this May 12, 2020
@RomanNikitenko RomanNikitenko added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 12, 2020
@azatsarynnyy azatsarynnyy mentioned this issue May 13, 2020
19 tasks
@azatsarynnyy azatsarynnyy added this to the 7.14 milestone May 14, 2020
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants