Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Improve running task process #742

Merged
merged 6 commits into from
May 19, 2020
Merged

Improve running task process #742

merged 6 commits into from
May 19, 2020

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented May 12, 2020

The PR depends on upstream changes.

What does this PR do?

  • Separates creating task terminal and running process logic:
    • creating terminal widget is moved from plugin side on client/browser side
    • running process logic stays on plugin side
  • reduces delay at creating remote terminal widget for che tasks as well as for che terminals
  • reduces delay at resolving a che task
  • fixes displaying a status marker for a terminal widget at running a vs code/theia task
  • provides an animated icon for a terminal tab while a task is running
  • fixes Run Last Task action for che tasks
  • fixes Attach Task action for che tasks
  • fixes a bugs like: CRW-444: The appropriate terminal tab doesn't open after launching predefined command in the associated workspace

What issues does this PR fix or reference?

How to test?

You can use the following devfile to test the changes or take only cheEditor component from my devfile and include it in your devfile.

Devfile
metadata:
  name: test-theia-tasks
projects:
  - name: che-theia
    source:
      location: 'https://github.com/eclipse/che-theia.git'
      type: git
components:
  - mountSources: true
    endpoints:
      - name: theia-dev-flow
        port: 3010
        attributes:
          protocol: http
          public: 'true'
    memoryLimit: 3Gi
    type: dockerimage
    image: 'quay.io/eclipse/che-theia-dev:next'
    alias: che-dev
  - id: redhat/vscode-yaml/latest
    type: chePlugin
  - id: che-incubator/typescript/latest
    memoryLimit: 1024M
    type: chePlugin
  - memoryLimit: 2Gi
    type: cheEditor
    reference: >-
      https://raw.githubusercontent.com/RomanNikitenko/che-plugin-registry/master/v3/plugins/eclipse/che-theia/next/meta.yaml
    alias: theia-editor
apiVersion: 1.0.0
commands:
  - name: 'che-theia:build'
    actions:
      - workdir: /projects/che-theia
        type: exec
        command: |
          yarn
        component: che-dev

  1. Try to run a terminal in different containers
  2. Try to run any kind of task (che, vs code/ theia) from Terminal ---> Run Task menu

running_tasks

  1. Try to use variables for workingDir and command fields

variables

  1. Try to play with component field
    component

  2. Try to use Run Last Task and Attach Task actions

attach

@RomanNikitenko RomanNikitenko added the kind/enhancement New feature or request label May 12, 2020
@RomanNikitenko RomanNikitenko self-assigned this May 12, 2020
@RomanNikitenko RomanNikitenko changed the title Improve running task Improve running task process May 12, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 12, 2020
@che-bot
Copy link
Contributor

che-bot commented May 14, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:742
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:742

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@RomanNikitenko
Copy link
Member Author

Theia master already contains user level tasks related changes, today I'm going to align my branch with theia master branch, fix compilation errors and test my changes.

@RomanNikitenko
Copy link
Member Author

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot May 18, 2020
@RomanNikitenko
Copy link
Member Author

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot May 18, 2020
@RomanNikitenko
Copy link
Member Author

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot May 18, 2020
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving it based on the demo I saw.
Great investigation and nice improvements! 👍

@RomanNikitenko
Copy link
Member Author

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot May 18, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 18, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 18, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 19, 2020
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@eclipse-che eclipse-che deleted a comment from che-bot May 19, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 19, 2020
@eclipse-che eclipse-che deleted a comment from azatsarynnyy May 19, 2020
@eclipse-che eclipse-che deleted a comment from azatsarynnyy May 19, 2020
@eclipse-che eclipse-che deleted a comment from che-bot May 19, 2020
@RomanNikitenko
Copy link
Member Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented May 19, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:742
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:742

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@RomanNikitenko
Copy link
Member Author

[ci-build]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants