Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Java 11 for quarkus stack as Java 8 is deprecated #16790

Closed
sunix opened this issue Apr 28, 2020 · 9 comments · Fixed by eclipse-che/che-plugin-registry#457 or eclipse-che/che-devfile-registry#269
Closed

use Java 11 for quarkus stack as Java 8 is deprecated #16790

sunix opened this issue Apr 28, 2020 · 9 comments · Fixed by eclipse-che/che-plugin-registry#457 or eclipse-che/che-devfile-registry#269
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.17

Comments

@sunix
Copy link
Contributor

sunix commented Apr 28, 2020 •
edited
Loading

Is your task related to a problem? Please describe.

Java 8 is deprecated https://quarkus.io/blog/quarkus-1-4-final-released/#whats-new

Describe the solution you'd like

Use Java 11 images (for runtime and plugin)
@sunix sunix added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Apr 28, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 28, 2020
@mmorhun mmorhun added area/stacks severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 29, 2020
sunix added a commit to eclipse-che/che-devfile-registry that referenced this issue Apr 30, 2020
@sunix
Use the quarkus java11 image in our quarkus stack
3fbeb65 
Partly solving eclipse-che/che#16790
@sunix sunix mentioned this issue Apr 30, 2020
Merged
@sunix
Copy link
Contributor Author

sunix commented May 2, 2020 •
edited
Loading

This is quite critical ... I don't know when the samples (used by our quarkus stack) will be updated and stop working with java8, so the sooner we fix that the better if we want to avoid a bad surprise seeing our quarkus stack broken.

sunix added a commit to eclipse-che/che-devfile-registry that referenced this issue May 3, 2020
@sunix
Use the quarkus java11 image in our quarkus stack
b9a6598 
Partly solving eclipse-che/che#16790
@sunix
Copy link
Contributor Author

sunix commented May 3, 2020

still the quarkus plugin to upgrade to Java11

@ericwill
Copy link
Contributor

ericwill commented May 4, 2020

@sunix if I provide a PR, can you test it against your flow?

@sunix
Copy link
Contributor Author

sunix commented May 4, 2020

@ericwill yes

This was referenced May 4, 2020
Merged
Closed
@sunix sunix reopened this May 7, 2020
@sunix
Copy link
Contributor Author

sunix commented May 7, 2020

reopening as the Quarkus stacks have to be updated

monaka pushed a commit to PizzaFactory/che-devfile-registry that referenced this issue May 10, 2020
@sunix @monaka
Use the quarkus java11 image in our quarkus stack
52d2197 
Partly solving eclipse-che/che#16790
@sunix
Copy link
Contributor Author

sunix commented May 11, 2020

reopening again

@sunix sunix reopened this May 11, 2020
@ericwill
Copy link
Contributor

@sunix am I to understand that we shouldn't offer Quarkus + Java 8 at all then?

@sunix
Copy link
Contributor Author

sunix commented Jul 13, 2020

yes we shouldn't offer java 8 : https://quarkus.io/blog/quarkus-1-4-final-released/#java-8-deprecated

@ericwill
Copy link
Contributor

yes we shouldn't offer java 8 : https://quarkus.io/blog/quarkus-1-4-final-released/#java-8-deprecated

Okay, I'll do the removal next sprint (187).

@ericwill ericwill mentioned this issue Jul 15, 2020
Closed
38 tasks
@ericwill ericwill added this to the 7.17 milestone Jul 15, 2020
@ericwill ericwill mentioned this issue Jul 17, 2020
Merged
ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue Jul 24, 2020
@ericwill
Deprecate quarkus-java8 plugins (#539)
97cd7b8 
* Remove some quarkus-java8 plugins and migrate quarkus-java8 1.5 to quarkus-java11

See eclipse-che/che#16790

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill ericwill mentioned this issue Jul 24, 2020
Merged
ericwill added a commit to eclipse-che/che-devfile-registry that referenced this issue Jul 24, 2020
@ericwill
Switch to quarkus-java11 by default (#269)
c0ae020 
Closes eclipse-che/che#16790

Signed-off-by: Eric Williams <ericwill@redhat.com>
monaka pushed a commit to PizzaFactory/che-plugin-registry that referenced this issue Aug 8, 2020
@ericwill @monaka
Deprecate quarkus-java8 plugins (eclipse-che#539)
c8c84ee 
* Remove some quarkus-java8 plugins and migrate quarkus-java8 1.5 to quarkus-java11

See eclipse-che/che#16790

Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.17
Development

Successfully merging a pull request may close this issue.

Add a quarkus-java11 plugin
Switch to quarkus-java11 by default
4 participants
@sunix @ericwill @mmorhun @che-bot