Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A task is not terminated by closing terminal #16919

Closed
1 of 3 tasks
RomanNikitenko opened this issue May 13, 2020 · 3 comments
Closed
1 of 3 tasks

A task is not terminated by closing terminal #16919

RomanNikitenko opened this issue May 13, 2020 · 3 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented May 13, 2020

Describe the bug

Usually a task is terminated by closing the corresponding terminal widget.
But it doesn't work after Storing the layout
Please see a short video in screenshot section

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Start any long running task (it doesn't matter - theia, vs code or che task)
  2. Close the terminal widget of the running task

Result: The task should be terminated.

  1. Open browser console
  2. Start any long running task (it doesn't matter - theia, vs code or che task)
  3. Wait root INFO >>> Storing the layout... log in browser console.
  4. Close the terminal widget of the running task

Result: The task is still running.
You can check it: go to Terminal --> Show running tasks

So to reproduce the bug you should:

  1. Open a terminal for a task
  2. Wait root INFO >>> Storing the layout... log in browser console.

Expected behavior

A task is terminated after closing its terminal.

Runtime

che.openshift.io

Screenshots

terminate_bug

@RomanNikitenko RomanNikitenko added the kind/bug Outline of a bug - must adhere to the bug report template. label May 13, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label May 13, 2020
@azatsarynnyy azatsarynnyy added area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels May 14, 2020
@RomanNikitenko
Copy link
Member Author

I tested this issue after merge eclipse-che/che-theia#742.
Looks like for che tasks it was fixed within eclipse-che/che-theia#742, but it's still actual for theia/vs code tasks.

Please see
terminate_shell_che

@che-bot
Copy link
Contributor

che-bot commented Jan 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021
@RomanNikitenko RomanNikitenko removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 11, 2021
@che-bot
Copy link
Contributor

che-bot commented Jul 19, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2021
@che-bot che-bot closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants