Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker LS not working in Quarkus stack #17123

Closed
4 of 22 tasks
Katka92 opened this issue Jun 9, 2020 · 7 comments
Closed
4 of 22 tasks

Docker LS not working in Quarkus stack #17123

Katka92 opened this issue Jun 9, 2020 · 7 comments
Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@Katka92
Copy link
Contributor

Katka92 commented Jun 9, 2020

Describe the bug

In a Quarkus example stack, the Docker language support is not present.

Che version

  • latest 7.14.1
  • nightly
  • other: please specify

Steps to reproduce

  1. Go to Get Started page
  2. Click on Quarkus Tools stack
  3. Wait for the workspace to start
  4. Open a file: quarkus-quickstarts - getting-started- src - main - docker - Dockerfile.jvm
  5. The plain text is displayed, even without coloring.

Expected behavior

There should be at least some basic LS support for Dockerfile.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version) 4.5
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Screenshot from 2020-06-09 17-05-59

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify
@Katka92 Katka92 added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 9, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 9, 2020
@tolusha tolusha added area/plugin-registry severity/P1 Has a major impact to usage or development of the system. kind/bug Outline of a bug - must adhere to the bug report template. and removed kind/bug Outline of a bug - must adhere to the bug report template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 10, 2020
@ScrewTSW
Copy link
Contributor

ScrewTSW commented Jul 8, 2020

Confirmed, syntax highlight still not present on Che 7.15.1

@ericwill
Copy link
Contributor

ericwill commented Jul 9, 2020

Confirmed, syntax highlight still not present on Che 7.15.1

Confirmed on che.openshift.io as well. It seems the "Language Mode" is set to Plain Text, when it really should be Dockerfile. When I change the language to Dockerfile it works fine.

I'm guessing it has something to do with the extension (i.e. .jvm or .native). If I create a file just named "Dockerfile" in the same folder the language is detected correctly.

@ericwill ericwill mentioned this issue Jul 15, 2020
38 tasks
@ericwill ericwill added this to the 7.17 milestone Jul 15, 2020
@vitaliy-guliy
Copy link
Contributor

Should be fixed by microsoft/vscode#103553

@vitaliy-guliy
Copy link
Contributor

vitaliy-guliy commented Jul 30, 2020

The fix is already in vscode master branch. There is a corresponding issue describing the problem microsoft/vscode#102897

Will be working soon after

@vitaliy-guliy
Copy link
Contributor

Reopened just to not be forgotten

@vitaliy-guliy vitaliy-guliy reopened this Jul 30, 2020
@vitaliy-guliy
Copy link
Contributor

Link with #17524

@ericwill
Copy link
Contributor

Adjusted the milestone to reflect that the issue will be fixed at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants