Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chectl server:start with minikube is failling #17142

Closed
sunix opened this issue Jun 11, 2020 · 26 comments
Closed

chectl server:start with minikube is failling #17142

sunix opened this issue Jun 11, 2020 · 26 comments
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/chectl Issues related to chectl, the CLI of Che kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Milestone

Comments

@sunix
Copy link
Contributor

sunix commented Jun 11, 2020

Describe the bug

Installing che with chectl on minikube (with default option) is failling.
Environment Linux and using the minikube driver kvm2

Here the steps:

  • install che in minikube
    image

  • got stuck at this step (will eventually fail with timeout)
    image

  • running the describe command
    image

  • showing the error
    image

@sunix sunix added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 11, 2020
@sunix sunix changed the title chectl minikube is failling chectl server:start with minikube is failling Jun 11, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 11, 2020
@sunix sunix added area/chectl Issues related to chectl, the CLI of Che severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 11, 2020
@sunix
Copy link
Contributor Author

sunix commented Jun 11, 2020

Setting blocker as it is stopping new user onbording with Che ... first time installation.

@dmytro-ndp
Copy link
Contributor

In Eclipse Che nightly tests the minikube has been started in no-driver mode:
minikube start --vm-driver=none --cpus 4 --memory 13000

@sunix
Copy link
Contributor Author

sunix commented Jun 11, 2020

@dmytro-ndp
ok but I don't have docker and don't want to install it.
Maybe all the commands and options you are running in the tests should be in the documentation as a recommanded options ....

@gattytto
Copy link

here's a workaround:
in /usr/local/lib/chectl/templates/che-operator/crds/org_v1_che_cr.yaml
MUST set:
tlsSupport: false
ingressDomain: 'your-local-ip.nip.io'

#16545 (comment)

@l0rd
Copy link
Contributor

l0rd commented Jun 15, 2020

@mmorhun are you looking at this?

@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Jun 15, 2020
@mmorhun mmorhun self-assigned this Jun 15, 2020
@mmorhun mmorhun added the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Jun 15, 2020
@mmorhun
Copy link
Contributor

mmorhun commented Jun 15, 2020

@sunix could you please provide minikube version ?

@sunix
Copy link
Contributor Author

sunix commented Jun 15, 2020

@mmorhun

$minikube version
minikube version: v1.11.0
commit: 57e2f55f47effe9ce396cea42a1e0eb4f611ebbd

@sunix sunix removed the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Jun 15, 2020
@gattytto
Copy link

gattytto commented Jun 15, 2020

this will keep happening until:

  1. temporary workaround is added to chectl consisted of:
    precreate storageclasses for postgres and workspaces and set them as settings in cr
    set tlsenabled: false as default instead of current :true in cr.yaml
    ingressDomain: is also needed in .cr, it does not get autofilled by chectl like before

  2. minikube upstream issue is fixed storage provisioner in v1.9.0-beta.2: Object: readObjectFieldAsBytes: expect : after object field,  kubernetes/minikube#7218

@gattytto
Copy link

#16409

@gattytto
Copy link

with mentioned workarounds in #16545 (comment):
image

image

@mmorhun
Copy link
Contributor

mmorhun commented Jun 15, 2020

set tlsenabled: false as default

@gattytto could you please elaborate more on this. Why is this required?

@gattytto
Copy link

gattytto commented Jun 15, 2020

set tlsenabled: false as default

@gattytto could you please elaborate more on this. Why is this required?

last time I tried with its default value, selfSignedCert: false is a default and tlsEnabled: true is default at the same time, which breaks. #16409

@gattytto
Copy link

when setting up in macOS using minikube and chectl + che-operator, there is the need of "minikube ssh" and "su", then "mkdir -p /data/wksp" and "chmod -R 777 /data", then chectl start command from macOS will work (after using the storageclass and cr.yaml workaround)

@mmorhun
Copy link
Contributor

mmorhun commented Jun 15, 2020

@gattytto I think problem with TLS will be gone after #16764 is fixed.

@gattytto
Copy link

timeout is also another blocker in this situation, because most of the times if no images are present in the vm, timeout won't be enough unless a very fast pc and a very fast internet is being used. Because of this first attempt of starting che will fail, making it needed to cleanup the postgres /userdata and recreating the storageclasses and volumes.

@mmorhun
Copy link
Contributor

mmorhun commented Jun 15, 2020

Our team is going to handle this issue in the next sprint. We already have similar issues/requests.

@mmorhun mmorhun added severity/P1 Has a major impact to usage or development of the system. and removed severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Jun 15, 2020
@mmorhun
Copy link
Contributor

mmorhun commented Jun 15, 2020

@gattytto thank you for deep investigations.
As about timeouts, I think that should be another issue....

@gattytto
Copy link

I think imagepulls should not be counted as part of the timeout

@mmorhun mmorhun added this to the Backlog - Deploy milestone Jun 18, 2020
@gattytto
Copy link

gattytto commented Jun 19, 2020

@mmorhun it seems like this is going to be fixed very soon upstream (check this commit as mentioned in kubernetes/minikube#7218 )

@tolusha tolusha mentioned this issue Jun 19, 2020
34 tasks
@mmorhun
Copy link
Contributor

mmorhun commented Jun 19, 2020

@gattytto I've seen priority/important-soon label, but thanks anyway for notifying.
I am working on workaround thought. It is useful in case if someone still wants to use Minikube from 1.9 to at least 1.11

@sunix
Copy link
Contributor Author

sunix commented Jun 19, 2020

@mmorhun why changing the severity?

@l0rd l0rd added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. and removed severity/P1 Has a major impact to usage or development of the system. labels Jun 22, 2020
@l0rd
Copy link
Contributor

l0rd commented Jun 22, 2020

@mkuznyetsov @nickboldt please wait for a fix for this issue before releasing 7.15.0.

@mmorhun
Copy link
Contributor

mmorhun commented Jun 23, 2020

Fixed

@l0rd
Copy link
Contributor

l0rd commented Jul 6, 2020

@flacatus @rhopp I was thinking about this and was wondering if we have any test for that. There were some e2e tests for chectl at some point, are they running? Aren't we testing minikube?

@tolusha tolusha modified the milestones: Backlog - Deploy, 7.16 Jul 8, 2020
@sunix
Copy link
Contributor Author

sunix commented Jul 13, 2020

@l0rd I think it is tested with -vm-driver=none option (using the docker engine of the host)

@gattytto
Copy link

minikube defaults to docker driver which uses docker-machine and a premade .iso.
minikube can also be run using driver=none and "--network-plugin=cni --enable-default-cni --container-runtime=cri-o" so it won't require docker and cri-o can be used, providing the cni binaries in /opt/cni/bin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/chectl Issues related to chectl, the CLI of Che kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Development

No branches or pull requests

7 participants