fix: Add workaround for Minikube storage provisioning bug #752
Conversation
mmorhun
changed the title
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
|
[test] |
src/tasks/platforms/minikube.ts
Outdated
| // To workaround the bug, it is required to patch storage provisioner as well as its permissions. | ||
| title: 'Patch minikube storage', | ||
| enabled: ctx => ctx.minikubeVersionMajor && ctx.minikubeVersionMinor && | ||
| ctx.minikubeVersionMajor === 1 && ctx.minikubeVersionMinor >= 9 && ctx.minikubeVersionMinor <= 11, |
There was a problem hiding this comment.
Why do we need to check that the version is <= 11? I mean I would set the upper bound only when we know which version of minikube will contain the fix. Otherwise we will get a blocker as soon as 1.12 is out.
There was a problem hiding this comment.
It is sort of a template when the bug is fixed. Seems there are some activity in the Minikube issue, so I hoped that it will be fixed soon. But agree, we'll add stop condition when Minikube fix arrives.
src/tasks/platforms/minikube.ts
Outdated
| kind: 'Pod', | ||
| spec: { | ||
| containers: [ | ||
| { name: 'storage-provisioner', image: 'gcr.io/k8s-minikube/storage-provisioner:latest' } |
There was a problem hiding this comment.
Instead of latest here we should use use the digest (or a version) to avoid that an update to latest breaks things.
There was a problem hiding this comment.
ok, I will use digest as there is no tag (if don't count latest) for the images above v1.8.1 which is 2 years old.
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
|
Tested with minikube 1.11 installation works fine. Workspaces starts too. |
|
Tested as well in my local machine with latest minikube version. |
Then we need set up argument |
In ci.centos unfortunetly we cannot use virtualbox or kvm2 drivers only --driver=none :( |
l0rd
added
the
new¬eworthy
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
Minikube starting from version
1.9has a bug which prevents Che and some other products from successful deployment. The root cause is the outdated storage-provisioner image and updating it to the latest version fixes the problem, but it also requires to add some permissions to the storage-provisioner cluster role. That is done in this PR on platform preparation phase.However, we should update range of Minikube versions for which this workaround is applied when Minikube with the fix released.
Tested with Minikube 1.11.0
What issues does this PR fix or reference?
eclipse-che/che#17142