Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[che-operator] As a developer, I do not want to manually generate / update a dozen of files for every PR #17338

Closed
ibuziuk opened this issue Jul 6, 2020 · 1 comment
Closed

[che-operator] As a developer, I do not want to manually generate / update a dozen of files for every PR #17338

ibuziuk opened this issue Jul 6, 2020 · 1 comment
Assignees
@AndrienkoAleksandr
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.21

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Jul 6, 2020 •
edited
Loading

Is your enhancement related to a problem? Please describe.

While working on a simple fix for #17186 it occurs that contribution to the operator requires quite a few steps - eclipse-che/che-operator#322 (comment)

  1. Update comment in che_types.go instead of org_v1_che_crd.yaml
  2. Launch olm/update-cr-crd-files.sh to correctly update org_v1_che_crd.yaml
  3. Launch olm/update-nightly-olm-files.sh to generate new nighly olm files
  4. Set 'spec.metrics.enabled: true' in both (kubernetes and openshift) new clusterserviceversion files
  5. Update both new (kubernetes and openshift) clusterserviceversion.yaml.diff files

Describe the solution you'd like

As a developer, I do not want to manually generate / update tons of files for every PR. From the 5 commits/steps I want to contibute only the first one - https://github.com/eclipse/che-operator/pull/322/commits (the rest 4 commits should be generated automatically by CI/bot)

Describe alternatives you've considered

Continue manual error-prone approach with the generation and editing files

Additional context

Examples of PRs where the change is simple / one-line fix but still 10+ files are manually generated :
@ibuziuk ibuziuk added kind/enhancement A feature request - must adhere to the feature request template. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Jul 6, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 6, 2020
@ibuziuk ibuziuk changed the title [che-operator] As a developer, I do not want to manually generate / update tons of files for every PR [che-operator] As a developer, I do not want to manually generate / update dozen of files for every PR Jul 6, 2020
@ibuziuk ibuziuk changed the title [che-operator] As a developer, I do not want to manually generate / update dozen of files for every PR [che-operator] As a developer, I do not want to manually generate / update a dozen of files for every PR Jul 6, 2020
@ibuziuk ibuziuk mentioned this issue Jul 6, 2020
Merged
@vparfonov vparfonov added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 6, 2020
@tolusha tolusha added this to the Backlog - Deploy milestone Sep 14, 2020
@AndrienkoAleksandr
Copy link
Contributor

We could try to use https://github.com/marketplace/actions/add-commit to automate nightly bundle update.

@tolusha tolusha modified the milestones: Backlog - Deploy, 7.21 Sep 30, 2020
@tolusha tolusha mentioned this issue Oct 1, 2020
Closed
50 tasks
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Oct 12, 2020
@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Oct 17, 2020
Merged
@tolusha tolusha closed this as completed Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrienkoAleksandr AndrienkoAleksandr

Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.21
Development

No branches or pull requests
5 participants
@ibuziuk @vparfonov @tolusha @AndrienkoAleksandr @che-bot