Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit new nightly bundle github action. #498

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Oct 17, 2020

Referenced issue:

eclipse-che/che#17338

What does this pull request do:

Add commit new nightly bundle github action: if developer changed deployment yaml files, then github action at the night should commit new bundle and bundle images will be pushed. If there is no changes in the deployment yamls - then nothing to commit.
Fix not needed push bundle images, when we have had already pushed images.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@tolusha
Copy link
Contributor

tolusha commented Oct 19, 2020

/test v5-che-operator-olm-latest-changes-tests

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AndrienkoAleksandr
Copy link
Contributor Author

[retest]

@flacatus
Copy link
Contributor

/retest

export GITHUB_WORKSPACE="${GOPATH}/src/github.com/eclipse/${{ github.repository }}" &&
cd ${GITHUB_WORKSPACE} && "${GITHUB_WORKSPACE}/.github/action_scripts/provideNewNightlyBundle.sh"

- name: Commit new nightly Olm bundle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about adding a custom message in the commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea, but I think, we can improve it in the next pr's.

@AndrienkoAleksandr AndrienkoAleksandr merged commit 0d51ea2 into eclipse-che:master Oct 20, 2020
@AndrienkoAleksandr AndrienkoAleksandr deleted the prepareNightlyBundleGithubAction branch October 20, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants