Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace wsmaster by eradicating problematic language #17602

Closed
benoitf opened this issue Aug 10, 2020 · 8 comments
Closed

Replace wsmaster by eradicating problematic language #17602

benoitf opened this issue Aug 10, 2020 · 8 comments
Labels
area/che-server kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Aug 10, 2020

Is your task related to a problem? Please describe.

wsmaster word is problematic and needs to be replaced

Describe the solution you'd like

Here are current proposals for the new name

  • wsserver
  • cheserver
  • api
  • controller

Additional context

if you have other proposals, please edit or comment this issue.
@benoitf benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-server labels Aug 10, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 10, 2020
@benoitf benoitf mentioned this issue Aug 10, 2020
Closed
9 tasks
@amisevsk
Copy link
Contributor

@benoitf @l0rd Not sure if this one would be considered P1 or P2 priority. I'm setting P2 for now but feel free to reassign.

I'll also add a 👎 to the name controller, since we've taken to calling the in-development operator the controller.

@amisevsk amisevsk added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 11, 2020
@benoitf
Copy link
Contributor Author

benoitf commented Aug 11, 2020

yes agree @amisevsk I put the controller as I heard it but probably it will not be picked up because the role of the controller is shifting to a different codebase

@nickboldt
Copy link
Contributor

wsserver seems the simplest solution to me, since it's the (master) server for workspaces.

@benoitf
Copy link
Contributor Author

benoitf commented Aug 17, 2020

@nickboldt yes the thing is that server is being "reduced" to REST services with the new dev workspace controller.

benoitf added a commit to benoitf/che-docs that referenced this issue Sep 11, 2020
@benoitf
replace wsmaster by {prod-short} server
00de14e 
eclipse-che/che#17602

Change-Id: I0250a5b6404e1fd15154374fccb658c8d612b9cf
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf mentioned this issue Sep 11, 2020
Merged
6 tasks
@skabashnyuk skabashnyuk mentioned this issue Oct 21, 2020
Closed
13 tasks
@che-bot
Copy link
Contributor

che-bot commented Mar 17, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@l0rd l0rd added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 24, 2021
@l0rd
Copy link
Contributor

l0rd commented Apr 20, 2021

That's a subtask of #17454

@nickboldt
Copy link
Contributor

so... is this issue done?

@nickboldt
Copy link
Contributor

Marking this resolved as things got merged and no one has commented since Sep 2021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-server kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nickboldt @benoitf @l0rd @amisevsk @che-bot