precreated namespaces with openshift <username> when OpenShift OAuth #18500
Labels
area/che-server
kind/enhancement
A feature request - must adhere to the feature request template.
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
severity/P1
Has a major impact to usage or development of the system.
Is your enhancement related to a problem? Please describe.
When we're looking for pre-created namespaces, we currently support only
<username>
placeholder, which is using che username. In case we're on OpenShift OAuth, we need to support openshift user as well.see discussion from this comment down #15323 (comment)
Q:
Do we need to support openshift userid as well ?
Describe the solution you'd like
Add placeholder for openshift username and search for such annotated namespaces.
The current default annotation is
che.infra.kubernetes.namespace.annotations=che.eclipse.org/username=<username>
(https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L271). Theche.infra.kubernetes.namespace.annotations
is list of annotations and current implementation is searching for namespaces with all the annotations in the list. This should be revisited, if we want change it to OR (so it could then beche.eclipse.org/username=<username>,che.eclipse.org/username=<openshift-username>
) or we'll choose different approach here.Describe alternatives you've considered
Additional context
#15323
The text was updated successfully, but these errors were encountered: