Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precreated namespaces with openshift <username> when OpenShift OAuth #18500

Closed
sparkoo opened this issue Dec 1, 2020 · 1 comment
Closed
Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@sparkoo
Copy link
Member

sparkoo commented Dec 1, 2020

Is your enhancement related to a problem? Please describe.

When we're looking for pre-created namespaces, we currently support only <username> placeholder, which is using che username. In case we're on OpenShift OAuth, we need to support openshift user as well.

see discussion from this comment down #15323 (comment)

Q:
Do we need to support openshift userid as well ?

Describe the solution you'd like

Add placeholder for openshift username and search for such annotated namespaces.

The current default annotation is che.infra.kubernetes.namespace.annotations=che.eclipse.org/username=<username> (https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L271). The che.infra.kubernetes.namespace.annotations is list of annotations and current implementation is searching for namespaces with all the annotations in the list. This should be revisited, if we want change it to OR (so it could then be che.eclipse.org/username=<username>,che.eclipse.org/username=<openshift-username>) or we'll choose different approach here.

Describe alternatives you've considered

Additional context

#15323

@sparkoo sparkoo added kind/enhancement A feature request - must adhere to the feature request template. area/che-server labels Dec 1, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 1, 2020
@sparkoo sparkoo changed the title search precreated namespaces with openshift <username> when OpenShift OAuth precreated namespaces with openshift <username> when OpenShift OAuth Dec 1, 2020
@RomanNikitenko RomanNikitenko added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 2, 2020
@che-bot
Copy link
Contributor

che-bot commented Jun 7, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2021
@che-bot che-bot closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants