Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github PR plugin: cannot signin if not done "on time". #18783

Closed
5 of 22 tasks
sunix opened this issue Jan 12, 2021 · 2 comments
Closed
5 of 22 tasks

Github PR plugin: cannot signin if not done "on time". #18783

sunix opened this issue Jan 12, 2021 · 2 comments
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@sunix
Copy link
Contributor

sunix commented Jan 12, 2021

Describe the bug

if the user don't click on the sign in button straight away, he won't be able to sign in later on.
This can happen if there is too many notifications and the request can be hidden by clone notification.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. start a workspace with the github pr plugin and a github project to clone.
  2. When the notification to sign in show up, Press ESC.
  3. The notification to sign in disapears.

Expected behavior

If you miss the sign in pop up, it is impossible to sign in again (command not available) -> need to restart again the workspace.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Selection_155

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify
@sunix sunix added the kind/bug Outline of a bug - must adhere to the bug report template. label Jan 12, 2021
@sunix sunix changed the title Github PR plugin: cannot sign in if not done on time. Github PR plugin: cannot signin if not done "on time". Jan 12, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 12, 2021
@sunix
Copy link
Contributor Author

sunix commented Jan 12, 2021

could be low priority if #18782 is fixed and user would have to sign in once only

@RomanNikitenko RomanNikitenko added area/plugins severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 12, 2021
@che-bot
Copy link
Contributor

che-bot commented Jul 19, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2021
@che-bot che-bot closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants