Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github PR plugin: restarting a workspace is asking again to sign in #18782

Closed
5 of 22 tasks
sunix opened this issue Jan 12, 2021 · 2 comments · Fixed by eclipse-che/che-plugin-registry#811
Closed
5 of 22 tasks
Assignees
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@sunix
Copy link
Contributor

sunix commented Jan 12, 2021

Describe the bug

Github PR plugin - Sign in is not persisted.

Che version

  • latest 7.24.0
  • nightly
  • other: please specify

Steps to reproduce

  1. start a workspace with the github pr plugin and a github project to clone.
  2. sign in as requested
  3. browse the gh panel -> ok
  4. restart the workspace
  5. sign in is requested again
  6. also IF YOU DO NOT CLICK Sign in on time (say you gone to take a coffee), it is impossible to sign in again (command not available) -> need to restart again the workspace. (created Github PR plugin: cannot signin if not done "on time". #18783)

Expected behavior

Should not request sign in again, information should be persisted.
Ideally it should be persisted in the user level (so sign in once, would work for any workspace started by the user)
If not, at least it should be persisted for the workspace.

Also for 6. should have a command to sign in. created a additional issue for that #18783

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Selection_154

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify
@sunix sunix added the kind/bug Outline of a bug - must adhere to the bug report template. label Jan 12, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 12, 2021
@RomanNikitenko RomanNikitenko added area/plugins severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 12, 2021
@ericwill ericwill added this to the 7.26 milestone Jan 12, 2021
@vinokurig vinokurig self-assigned this Jan 14, 2021
@ericwill ericwill mentioned this issue Jan 14, 2021
33 tasks
@vinokurig
Copy link
Contributor

is fixed by eclipse-che/che-plugin-registry#798

@sunix
Copy link
Contributor Author

sunix commented Jan 20, 2021

@vinokurig I am reopening the issue as it has been reverted eclipse-che/che-plugin-registry@aeb6ffb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants