Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to build custom registries using OpenShift Build #18798

Closed
l0rd opened this issue Jan 13, 2021 · 2 comments
Closed

Allow to build custom registries using OpenShift Build #18798

l0rd opened this issue Jan 13, 2021 · 2 comments
Labels
area/devfile-registry area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Jan 13, 2021

Is your enhancement related to a problem? Please describe.

The guide to build custom registries tells to run the script build.sh at the root of the registry repository. That script does a docker build.

The problem is that users may not have the privileges to run docker in their enterprise network and won't be able to build a custom registry.

Describe the solution you'd like

Add an option to use buildah rather than docker.

Describe alternatives you've considered

Add an option to build.sh to use OpenShift build rather than Docker. For example using oc start build.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 13, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 13, 2021
@benoitf benoitf added area/devfile-registry area/plugin-registry severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 13, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Jan 15, 2021

As discussed at prioritization we are going to start with adding a buildah/podman option.

@mbenitez1607 mbenitez1607 added this to the 7.26 milestone Jan 18, 2021
ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue Jan 29, 2021
* Add support for building with buildah/podman/docker

Not all users have access to docker, so auto-detect whichever tool is available and working.

Part of eclipse-che/che#18798

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Fix README to better describe the new approaches

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Add bud as build command, if BUILDER=buildah

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Use BUILDER=docker in all CI jobs and devfile build

Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill added a commit to eclipse-che/che-devfile-registry that referenced this issue Jan 29, 2021
Not all users have access to docker, so use podman/buildah by default and use docker as a last resort.

Part of eclipse-che/che#18798

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill
Copy link
Contributor

Both registries support building with podman/buildah now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants