Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openvsx dropped some extensions #18933

Closed
3 tasks
benoitf opened this issue Feb 1, 2021 · 11 comments
Closed
3 tasks

Openvsx dropped some extensions #18933

benoitf opened this issue Feb 1, 2021 · 11 comments
Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.

Comments

@benoitf
Copy link
Contributor

benoitf commented Feb 1, 2021

Describe the bug

Eclipse Che plug-in registry is referencing some extensions that have been dropped from OpenVsx registry

example: bash-debug
it was on openvsx/ google referenced it
image

but today https://open-vsx.org/extension/rogalmic/bash-debug is returning 404 error

Should be related to the final date of "publishing agreement deadline of January 29, 2021"
It makes impossible to build plugin registry without cache and workspaces using these plug-ins will fail

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

Expected behavior

Working VS Code extensions

@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. area/plugin-registry labels Feb 1, 2021
@sunix
Copy link
Contributor

sunix commented Feb 1, 2021

Sounds blocker to me:

  • new builds are failing
  • workspaces may fail to start if devfile using one of the missing extensions

@sunix
Copy link
Contributor

sunix commented Feb 1, 2021

To prevent the problem for the user at runtime, we could make the plugins available "offline" in the registry.
Could not be done for all plugins so we would need to have a denylist for those the license don't authorize to redistribute.

Currently the gh action build is not failing thanks to gh-action cache

@benoitf benoitf added the severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. label Feb 1, 2021
@brianking
Copy link

This was just discussed on the community call. Can someone summarize the proposed solution?

@ericwill
Copy link
Contributor

ericwill commented Feb 1, 2021

This was just discussed on the community call. Can someone summarize the proposed solution?

I believe the way forward is:

  • Remove the problematic devfiles/plugins for now
  • Find replacement links to update the plugin registry
  • Enable offline builds in the plugin registry by default so that all vsix files are downloaded at build time
  • Re-introduce the devfiles that were removed

ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue Feb 1, 2021
* Temporarily remove some plugins where vsix files are missing

Part of eclipse-che/che#18933

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Update bash-debug location instead of removing

Signed-off-by: Eric Williams <ericwill@redhat.com>
@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 2, 2021

@ericwill how about we contact the authors of the plugins in question and get them to sign? Has this been explored?

Enable offline builds in the plugin registry by default so that all vsix files are downloaded at build time

We need to be aware that we're crossing a line between referencing and distributing here. Not saying it's a problem, but the licensing requirements are different.

@sunix
Copy link
Contributor

sunix commented Feb 2, 2021

@sunix
Copy link
Contributor

sunix commented Feb 2, 2021

@tsmaeder about offline mode: #18933 (comment)

To prevent the problem for the user at runtime, we could make the plugins available "offline" in the registry.
Could not be done for all plugins so we would need to have a denylist for those the license don't authorize to redistribute.

@ibuziuk
Copy link
Member

ibuziuk commented Feb 2, 2021

@sunix @ericwill could you please cherry-pick relevants PRs for fixing bash devfile for 7.25.x ? we would like to have a fix in the 7.25.2 that is planned for tomorrow.

ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue Feb 2, 2021
…829)

* Temporarily remove some plugins where vsix files are missing

Part of eclipse-che/che#18933

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Update bash-debug location instead of removing

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill
Copy link
Contributor

ericwill commented Feb 2, 2021

@sunix @ericwill could you please cherry-pick relevants PRs for fixing bash devfile for 7.25.x ? we would like to have a fix in the 7.25.2 that is planned for tomorrow.

All relevant PRs have been cherry-picked.

@sunix
Copy link
Contributor

sunix commented Feb 8, 2021

I am closing this one as it looks like everything has been merged/cherry-picked

@sunix sunix closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Development

No branches or pull requests

6 participants