Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor che-operator controller #19978

Closed
Tracked by #20404
tolusha opened this issue Jun 16, 2021 · 1 comment
Closed
Tracked by #20404

Refactor che-operator controller #19978

tolusha opened this issue Jun 16, 2021 · 1 comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@tolusha
Copy link
Contributor

tolusha commented Jun 16, 2021

Is your task related to a problem? Please describe.

Operator has to update its status more often once error is occurred.
It allows chectl (or another tool) to monitor and report problem earlier than timeout happens.

Describe the solution you'd like

  1. Refactor controller to have something like this
	for _, syncItem := range syncItems {
		done, err := syncItem(deployContext)
		if !util.IsTestMode() {
			if err != nil {
				// set status
			} else {
				// clean up status
			}
			if !done {
				return reconcile.Result{}, nil
			}
		}
	}
  1. chectl should not fail immediately but allow operator fix problem on the next reconcile loop

Describe alternatives you've considered

N/A

Additional context

[1] Installing Che using chectl with the operator fails earlier when a problem occurs #19284

@tolusha tolusha added kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/next severity/P2 Has a minor but important impact to the usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator team/deploy labels Jun 16, 2021
@tolusha tolusha mentioned this issue Jul 7, 2021
24 tasks
@tolusha tolusha added this to the 7.34 milestone Jul 8, 2021
@tolusha tolusha modified the milestones: 7.34, 7.35 Jul 28, 2021
@tolusha tolusha mentioned this issue Aug 16, 2021
19 tasks
@tolusha tolusha removed this from the 7.35 milestone Aug 16, 2021
@tolusha tolusha mentioned this issue Sep 3, 2021
29 tasks
@tolusha tolusha added this to the 7.37 milestone Sep 8, 2021
@tolusha tolusha mentioned this issue Sep 27, 2021
27 tasks
@tolusha tolusha modified the milestones: 7.37, 7.38 Sep 28, 2021
@tolusha
Copy link
Contributor Author

tolusha commented Oct 19, 2021

Close this issue in favor of #19284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

1 participant