Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing Che using chectl with the operator fails earlier when a problem occurs #19284

Closed
Tracked by #20085 ...
l0rd opened this issue Mar 15, 2021 · 3 comments
Closed
Tracked by #20085 ...
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Mar 15, 2021

Is your enhancement related to a problem? Please describe.

When Che is deployed using chectl and Che operator fails to create resources, user is acknowledged when timeout is reached (after a few minutes).

Describe the solution you'd like

Fails installation as soon as the operator fails to create a resource.

Additional context

As an example, when I faced this issue, chectl continued running for a few minutes (although the operator had a lot of errors in its log) and then failed for timeout:

chectl server:deploy --che-operator-cr-patch-
yaml=patch.yaml -p openshift --no-olm-suggested-namespace -n workspaces-server
› Installer type is set to: 'olm'
› Current Kubernetes context: 'admin'
  ✔ Verify Kubernetes API...OK (it's OpenShift)
  ✔ 👀  Looking for an already existing Eclipse Che instance
    ✔ Verify if Eclipse Che is deployed into namespace "workspaces-server"...it is not
  ✔ ✈️  Openshift preflight checklist
    ✔ Verify if oc is installed...done.
    ✔ Verify if openshift is running...done.
    ✔ Check OpenShift version: 4.x
    ✔ Check Kubernetes version: Unknown.
  ✔ Following Eclipse Che logs
    ✔ Start following Operator logs...done
    ✔ Start following Eclipse Che server logs...done
    ✔ Start following Postgres logs...done
    ✔ Start following Keycloak logs...done
    ✔ Start following Plugin registry logs...done
    ✔ Start following Devfile registry logs...done
    ✔ Start following namespace events...done
  ✔ 🏃‍  Running Olm installaion Eclipse Che
    ✔ Check if OLM is pre-installed on the platform...done.
    ✔ Create Namespace (workspaces-server)...Done.
    ✔ Create operator group...created new one.
    ✔ Configure context information...done.
    ✔ Create nightly index CatalogSource in the namespace workspaces-server
    ✔ Create operator subscription...created new one.
    ✔ Wait while subscription is ready...done.
    ✔ Wait while operator installed...done.
    ✔ Prepare Eclipse Che cluster CR...Done.
    ✔ Create the Custom Resource of type checlusters.org.eclipse.che in the namespace workspaces-server...done.
  ❯ ✅  Post installation checklist
    ❯ PostgreSQL pod bootstrap
      ✖ Scheduling
        → Timeout: there are no pods in the namespace: workspaces-server, selector: app=che,component=postgres. Check Eclip
…
        Downloading images
        Starting
      Keycloak pod bootstrap
      Devfile registry pod bootstrap
      Plugin registry pod bootstrap
      Eclipse Che pod bootstrap
      Eclipse Che status check
    Retrieving Keycloak admin credentials
    Retrieving Che self-signed CA certificate
    Prepare post installation output
 ›   Error: Error: Timeout: there are no pods in the namespace: workspaces-server, selector: app=che,component=postgres.
 ›   Check Eclipse Che logs for details. Consider increasing error recheck timeout with --k8spoderrorrechecktimeout flag.
 ›   Command server:deploy failed. Error log: /Users/mloriedo/Library/Caches/chectl/error.logchectl server:deploy --che-operator-cr-patch-
yaml=patch.yaml -p openshift --no-olm-suggested-namespace -n workspaces-server
› Installer type is set to: 'olm'
› Current Kubernetes context: 'admin'
  ✔ Verify Kubernetes API...OK (it's OpenShift)
  ✔ 👀  Looking for an already existing Eclipse Che instance
    ✔ Verify if Eclipse Che is deployed into namespace "workspaces-server"...it is not
  ✔ ✈️  Openshift preflight checklist
    ✔ Verify if oc is installed...done.
    ✔ Verify if openshift is running...done.
    ✔ Check OpenShift version: 4.x
    ✔ Check Kubernetes version: Unknown.
  ✔ Following Eclipse Che logs
    ✔ Start following Operator logs...done
    ✔ Start following Eclipse Che server logs...done
    ✔ Start following Postgres logs...done
    ✔ Start following Keycloak logs...done
    ✔ Start following Plugin registry logs...done
    ✔ Start following Devfile registry logs...done
    ✔ Start following namespace events...done
  ✔ 🏃‍  Running Olm installaion Eclipse Che
    ✔ Check if OLM is pre-installed on the platform...done.
    ✔ Create Namespace (workspaces-server)...Done.
    ✔ Create operator group...created new one.
    ✔ Configure context information...done.
    ✔ Create nightly index CatalogSource in the namespace workspaces-server
    ✔ Create operator subscription...created new one.
    ✔ Wait while subscription is ready...done.
    ✔ Wait while operator installed...done.
    ✔ Prepare Eclipse Che cluster CR...Done.
    ✔ Create the Custom Resource of type checlusters.org.eclipse.che in the namespace workspaces-server...done.
  ❯ ✅  Post installation checklist
    ❯ PostgreSQL pod bootstrap
      ✖ Scheduling
        → Timeout: there are no pods in the namespace: workspaces-server, selector: app=che,component=postgres. Check Eclip
…
        Downloading images
        Starting
      Keycloak pod bootstrap
      Devfile registry pod bootstrap
      Plugin registry pod bootstrap
      Eclipse Che pod bootstrap
      Eclipse Che status check
    Retrieving Keycloak admin credentials
    Retrieving Che self-signed CA certificate
    Prepare post installation output
 ›   Error: Error: Timeout: there are no pods in the namespace: workspaces-server, selector: app=che,component=postgres.
 ›   Check Eclipse Che logs for details. Consider increasing error recheck timeout with --k8spoderrorrechecktimeout flag.
 ›   Command server:deploy failed. Error log: /Users/mloriedo/Library/Caches/chectl/error.log

Release Notes Text

When a problem occurred during the installing of Che using chectl with the operator, users had to wait until a timeout occurred and a confusing error was presented to them. Now the installation fails as soon as the error occurs.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Mar 15, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 15, 2021
@l0rd l0rd added area/chectl Issues related to chectl, the CLI of Che severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 15, 2021
@l0rd l0rd changed the title chectl should fail earlier when che operator fails Installing Che using chectl with the operator fails earlier when a problem occurs Jun 1, 2021
@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Jun 1, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Jun 2, 2021

@tolusha I think we can close this issue right? And the milestone should be 7.32?

@tolusha
Copy link
Contributor

tolusha commented Jun 2, 2021

@l0rd
Not exactly.
Some changes has been made to chectl to fail earlier.
But it is also required changes che-operator for updating its status more often (after each error).
Currently I don't see how we can do that. It might lead to another issues, when chectl will fail when it should not.
So, I postponed it for a while.

@tolusha tolusha removed this from the 7.35 milestone Aug 16, 2021
@tolusha tolusha mentioned this issue Sep 3, 2021
29 tasks
@tolusha tolusha added this to the 7.37 milestone Sep 8, 2021
@wbondarchuk
Copy link

Hello, did you solve this issue? I meet this too and i will break my head soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants