Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native auth breaks Che when it's enabled on an existing instance #20291

Closed
sleshchenko opened this issue Aug 12, 2021 · 3 comments
Closed

Native auth breaks Che when it's enabled on an existing instance #20291

sleshchenko opened this issue Aug 12, 2021 · 3 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@sleshchenko
Copy link
Member

Describe the bug

Native auth breaks Che when it's enabled on an existing instance.

Che version

next (development version)

Steps to reproduce

  1. Deploy Che on OpenShift without native auth: chectl server:deploy --installer=operator --platform=openshift
  2. Open and access with user.
  3. Configure Che Cluster with devworkspace enabled
    oc patch checluster/eclipse-che --type=merge --patch '{"spec":{"devWorkspace": {"enable": true}}}'
  4. Try to access Che now.

Expected behavior

Che is working after devworkspace is enabled (where native auth is the default)

Notes: each of public endpoints have its own route but everything should go though gateway.
keycloak deployment is not removed (maybe it's kept for an ability to restore keycloak auth).

Runtime

OpenShift

Screenshots

Screenshot_20210812_141848

Installation method

chectl/next

Environment

other (please specify in additional context)

Eclipse Che Logs

No response

Additional context

RHPDS OpenShift 4.8

@sleshchenko sleshchenko added kind/bug Outline of a bug - must adhere to the bug report template. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Aug 12, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 12, 2021
@SkorikSergey SkorikSergey added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 12, 2021
@tolusha tolusha added the engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. label Aug 12, 2021
@sparkoo
Copy link
Member

sparkoo commented Aug 19, 2021

I've tested that and it looks like issue is not in native auth directly. When I enable devworkspace, che-operator should deploy gateway, which is not happening. And native auth can't work without gateway. Also nativeUserMode: true is set properly in CheCluster, but keycloak deployment is still there. I guess the issue is deeper in che-operator than just native auth.

@sparkoo
Copy link
Member

sparkoo commented Aug 19, 2021

server.serverExposureStrategy must be set to single-host to deploy the gateway. However, keycloak deployment is stil there, even though auth.nativeUserMode is set to true. However, native auth is effectively enabled. It still not fully work as I can't get the workspace started. I'm not sure exactly why. Currently I don't want to dig deeper, but maybe we should start broader discussion about updating Che to devworkspaces

@tolusha
Copy link
Contributor

tolusha commented Jan 10, 2022

I mark this issue as WON'T FIX for several reason:

  • Dev Workspace is enabled by default sinse 7.42 [1]
  • Switching must be done via migration guide [2]

[1] #20866
[2] #20614

@tolusha tolusha closed this as completed Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants