Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code of SFTP back up flow #20836

Closed
Tracked by #20839
mmorhun opened this issue Nov 29, 2021 · 2 comments
Closed
Tracked by #20839

Improve code of SFTP back up flow #20836

mmorhun opened this issue Nov 29, 2021 · 2 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@mmorhun
Copy link
Contributor

mmorhun commented Nov 29, 2021

Is your task related to a problem? Please describe

Current flow is not optimal. We should improve it.

Describe the solution you'd like

Refactor code that is responsible for SFTP backup flow

Describe alternatives you've considered

No response

Additional context

No response

@mmorhun mmorhun added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator team/deploy labels Nov 29, 2021
@benoitf benoitf changed the title Improce code of SFTP back up flow Improve code of SFTP back up flow Nov 29, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 29, 2021
@tolusha tolusha mentioned this issue Nov 29, 2021
28 tasks
@svor svor added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 30, 2021
@tolusha tolusha modified the milestones: 7.40, 7.41 Dec 1, 2021
@tolusha tolusha removed this from the 7.41 milestone Dec 17, 2021
@mmorhun
Copy link
Contributor Author

mmorhun commented Dec 17, 2021

When I started looking into this issue, I found that SFTP backup mechanism is broken.
Short investigation showed that there are 3 problems (all is caused by random user ID in the Che Operator container):

  1. User home is not writable (defined as /), so it fails to update ssh config in ~/.ssh folder. A quick fix is to add the following line in Dockerfile: env HOME=/tmp/
  2. No ssh client in UBI image. To fix, just install openssh-clients package using microdnf install -y openssh-clients or add the package to already existing install command
  3. ssh fails to open connection with the following error: No user exists for uid xxxx. This cause by absent record in passswd file. To fix, add write permissions for the /etc/passwd and add current user record in entrypoint script.

Edit: SFTP backup mechanism should be fixed by eclipse-che/che-operator#1271 , however it doesn't fix original issue

@tolusha
Copy link
Contributor

tolusha commented Feb 4, 2022

WON'T FIX
Backup/Restore is flaky and doesn't works with DevWorkspace
Decommissioned by #21006

@tolusha tolusha closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants