Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CheCluster field headerMessage.warning -> headerMessage.text #21628

Closed
Tracked by #21615
tolusha opened this issue Aug 10, 2022 · 0 comments
Closed
Tracked by #21615

Rename CheCluster field headerMessage.warning -> headerMessage.text #21628

tolusha opened this issue Aug 10, 2022 · 0 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.52

Comments

@tolusha
Copy link
Contributor

tolusha commented Aug 10, 2022

Is your task related to a problem? Please describe

There is a typo in [1] after switching to CheCluster API v2:

Text string `json:"warning,text"`

[1] https://github.com/eclipse-che/che-operator/blob/defec6763eac26cd2c23a5f4f6d4d68b1db17419/api/v2/checluster_types.go#L356

Describe the solution you'd like

It must be:

Text string `json:"text,omitempty"`

Describe alternatives you've considered

No response

Additional context

No response
@tolusha tolusha added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Aug 10, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 10, 2022
@tolusha tolusha mentioned this issue Aug 10, 2022
Merged
11 tasks
@tolusha tolusha added this to the 7.52 milestone Aug 10, 2022
@tolusha tolusha closed this as completed Aug 10, 2022
@benoitf benoitf added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 10, 2022
@tolusha tolusha mentioned this issue Aug 10, 2022
Closed
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.52
Development

No branches or pull requests
3 participants
@benoitf @tolusha @che-bot