Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Workspace from Local Devfile command should be more informative when devfile is not valid #22913

Closed
svor opened this issue Apr 9, 2024 · 0 comments
Assignees
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.

Comments

@svor
Copy link
Contributor

svor commented Apr 9, 2024

Is your task related to a problem? Please describe

After changing the devfile by making it invalid, the Restart Workspace from Local Devfile command fails and it is expected, but the reason of the failure is not clear.

I've started the workspace via https://github.com/che-samples/web-nodejs-sample and made next changes in the devfile:

components:
  - name: tools
    container:
      image: quay.io/devfile/universal-developer-image:latest
      endpoints:
        - exposure: public
          name: nodejs
          protocol: http
          targetPort: 3000
      memoryLimit: 1G
      mountSources: true
      env:
        - name: KUBEDOCK_ENABLE
          value: true

NOTE: value: true is not valid, it should be value: "true"

screenshot-nimbusweb me-2024 04 09-12_03_02

Describe the solution you'd like

It would be nice to see the reason of failure instead of Something went wrong for the 'Restart From Local Devfile' action: HttpError: HTTP request failed

Describe alternatives you've considered

maybe we should use devfile schema validator during the restart and show the real problem.
We've added the validator into devworkspace generator tool: eclipse-che/che-devfile-registry#796

Additional context

If vscode-yaml extension is installed in the workspace, it shows this problem in the editor:
screenshot-nimbusweb me-2024 04 09-12_28_07

@svor svor added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Apr 9, 2024
@vitaliy-guliy vitaliy-guliy self-assigned this Apr 9, 2024
@svor svor added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 9, 2024
@AObuchow AObuchow added area/editor/vscode Issues related to the Code OSS editor of Che and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 10, 2024
@svor svor added team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. severity/P2 Has a minor but important impact to the usage or development of the system. labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants