-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make workspace restart more informative #363
Conversation
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Pull Request Dev image published: |
Pull Request Dev image published: |
Pull Request Dev image published: |
Pull Request Dev image published: |
Pull Request Dev image published: |
Pull Request Che-Code image published: |
@@ -41,7 +41,8 @@ | |||
"@types/fs-extra": "^9.0.13", | |||
"@types/jest": "^27.4.0", | |||
"@types/js-yaml": "^4.0.5", | |||
"@types/node": "18.x" | |||
"@types/node": "18.x", | |||
"eslint": "^8.0.0" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update yarn.lock file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Pull Request Dev image published: |
Pull Request Che-Code image published: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested,
works as described in the PR description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 3.15 :: code_3.x/1414: Console, Changes, Git Data |
Build 3.15 :: sync-to-downstream_3.x/6905: Console, Changes, Git Data |
Build 3.15 :: push-latest-container-to-quay_3.x/4667: Console, Changes, Git Data |
Build 3.15 :: get-sources-rhpkg-container-build_3.x/6855: code : 3.x :: Build 61609548 : quay.io/devspaces/code-rhel8:3.15-1 |
Build 3.15 :: update-digests_3.x/6709: Console, Changes, Git Data |
Build 3.15 :: code_3.x/1414: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6905 triggered |
Build 3.15 :: operator-bundle_3.x/3080: Console, Changes, Git Data |
Build 3.15 :: sync-to-downstream_3.x/6907: Console, Changes, Git Data |
Build 3.15 :: get-sources-rhpkg-container-build_3.x/6857: devspaces-operator-bundle : 3.x :: Failed in 61615147 : BREW:BUILD/STATUS:UNKNOWN |
This change is great @vitaliy-guliy, thank you! I found one edge case: If the ServiceAccount running the DevWorkspace Pod does not have the appropriate k8s Role (permissions), you still get ambiguous HTTP Request errors when trying to perform actions such as "Dev Spaces: Restart Workspace from Local Devfile." I discovered this when I had to override the default ServiceAccount so I could apply a custom SecurityContextContstraing and some extra securityContext for a special container component that had to run as a non-random user. |
What does this PR do?
@eclipse-che/che-devworkspace-generator:7.86.0
What issues does this PR fix?
eclipse-che/che#22913
How to test this PR?
.devfile.yaml
and make some invalid change. I usually add the container environment variableThe
yaml
extension should underlinetrue
as one that has wrong type (considering devfile schema it should be string instead of boolean).run
Eclipse Che: Restart Workspace from Local Devfile
command and select the devfile( if there is only one devfile in the project, you can press
Enter
several times to confirm the reload )at this step you should be warned with an explanation of the reason of failure
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebase
were added to the .rebase folder