Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard is not able to cache factories #4907

Closed
sleshchenko opened this issue Apr 25, 2017 · 0 comments
Closed

Dashboard is not able to cache factories #4907

sleshchenko opened this issue Apr 25, 2017 · 0 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@sleshchenko
Copy link
Member

Dashboard fetches factories each time instead of using cache with etag like he does with entities on other pages.

Reproduction Steps:

  1. Create at least one factory in che.
  2. Open factories page on dashboard and check requests list
    image

Expected: First request returns 200 response code and next requests return 304.
Actual: All requests returns 200.

It works in this way because of wrong accepted rel that contains hash of GuiceUriBuilderImpl instance instead of link.

{
  "v": "4.0",
  "name": "test",
  ...
  "links": [
    ...
    {
      "href": "org.everrest.guice.GuiceUriBuilderImpl@7dcf6b95",
      "parameters": [],
      "rel": "accepted",
      "method": "GET",
      "produces": "text/plain"
    }
    ...
  ]
}
@sleshchenko sleshchenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Apr 25, 2017
@ashumilova ashumilova added severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/plugin labels Apr 25, 2017
@ashumilova ashumilova added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Apr 25, 2017
@ashumilova ashumilova added this to the 5.10 milestone Apr 25, 2017
@sleshchenko sleshchenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 27, 2017
@skabashnyuk skabashnyuk modified the milestones: 5.10, 5.10.0 Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants